Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser,ddl: parse and ignore 'PARTITION BY LIST ..." #11236

Merged
merged 4 commits into from
Jul 18, 2019
Merged

parser,ddl: parse and ignore 'PARTITION BY LIST ..." #11236

merged 4 commits into from
Jul 18, 2019

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

On the release-2.1 branch, TiDB fails to execute the following SQL:

create table t (a int) /*!50100 partition by list (a) (
partition p0 values in (1) ENGINE = InnoDB,
partition p1 values in (29) ENGINE = InnoDB,
partition p2 values in (2) ENGINE = InnoDB,
partition p3 values in (3) ENGINE = InnoDB) */

What is changed and how it works?

Update parser, parse PARTITION BY LIST and ignore it.

Check List

Tests

  • Unit test

@tiancaiamao
Copy link
Contributor Author

Wait for pingcap/parser#386

@jackysp jackysp added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Jul 18, 2019
@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

lysu
lysu reviewed Jul 18, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat
Copy link

@tiancaiamao please fix ci.

@kennytm kennytm added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2019
@tiancaiamao
Copy link
Contributor Author

The parser was updated in #11306

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

zz-jason
zz-jason approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor Author

/run-unit-test

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 18, 2019
@zz-jason zz-jason merged commit 9a76296 into pingcap:release-2.1 Jul 18, 2019
@tiancaiamao tiancaiamao deleted the 2.1-partition-by-list branch July 18, 2019 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/parser priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tiancaiamao @imtbkcat @lysu @zz-jason @kennytm @july2993 @jackysp