Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: add 3 fields to statement summary table (#14096) #14168

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

djshow832
Copy link
Contributor

conflicting files:
const.go

What problem does this PR solve?

Add 3 more fields to events_statements_summary_by_digest:

  • SUMMARY_END_TIME: the end time of current summary.
  • SUM_BACKOFF_TIMES: the total backoff times of this kind of SQL.
  • PREV_SAMPLE_TEXT: the previous SQL before current SQL if current SQL is commit.

What is changed and how it works?

  • SUMMARY_END_TIME: the end time will change if refreshInterval changes.
  • PREV_SAMPLE_TEXT: the identifier of each kind of SQL is composed of previous digest and current digest, so it can distinguish different types of transactions.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • Add 3 more fields to table events_statements_summary_by_digest:
    SUMMARY_END_TIME: the end time of current summary.
    SUM_BACKOFF_TIMES: the total backoff times of this kind of SQL.
    PREV_SAMPLE_TEXT: the previous SQL before current SQL if current SQL is commit.

@djshow832 djshow832 added priority/release-blocker This issue blocks a release. Please solve it ASAP. type/usability type/3.0 cherry-pick labels Dec 20, 2019
@djshow832
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 merged commit b47381b into pingcap:release-3.0 Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. type/usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants