Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: avoid panic when creating partition table with unsupported expression(#14295) #14769

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

imtbkcat
Copy link

@imtbkcat imtbkcat commented Feb 13, 2020

What problem does this PR solve?

cherry-pick #14295
with conflict fixed.

@imtbkcat imtbkcat changed the title ddl: avoid panic when creating partition table with unsupported expre… ddl: avoid panic when creating partition table with unsupported expression(#14295) Feb 13, 2020
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 24, 2020
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Feb 25, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 25, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 25, 2020

Your auto merge job has been accepted, waiting for 14862

@sre-bot
Copy link
Contributor

sre-bot commented Feb 25, 2020

/run-all-tests

@sre-bot sre-bot merged commit 037b369 into pingcap:release-3.0 Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants