Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session/statistics: discard feedbacks from `delete ... (#17452) #17843

Merged
merged 5 commits into from
Jun 19, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 8, 2020

cherry-pick #17452 to release-4.0


What problem does this PR solve?

Issue Number: close #17438

Problem Summary:

Feedbacks from update, delete may be invalid.

What is changed and how it works?

What's Changed:

Discard those feedbacks.

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Discard feedbacks generated from delete / update statements.

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 8, 2020

/run-all-tests

@you06
Copy link
Contributor

you06 commented Jun 9, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 9, 2020

Sorry @you06, you don't have permission to trigger auto merge event on this branch.
The version releasement is in progress.

@you06
Copy link
Contributor

you06 commented Jun 9, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 9, 2020

/run-all-tests

@you06 you06 removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 10, 2020
@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason linked an issue Jun 11, 2020 that may be closed by this pull request
@zz-jason zz-jason added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Jun 19, 2020
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/can-merge Indicates a PR has been approved by a committer. label Jun 19, 2020
@zz-jason
Copy link
Member

/merge

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 19, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@eurekaka
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@sre-bot merge failed.

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@sre-bot merge failed.

@zz-jason
Copy link
Member

/run-sqllogic-test-2

@zz-jason zz-jason changed the title session/statistics: discard feedbacks from delete / update (#17452) session/statistics: discard feedbacks from `delete ... (#17452) Jun 19, 2020
@zz-jason zz-jason merged commit 99dc723 into pingcap:release-4.0 Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics epic/query-feedback-GA priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

discard feedbacks from delete / update statements
7 participants