executor: resolve errors caused by in null in point/batch ...
#18848
Conversation
|
/run-all-tests |
|
LGTM |
|
/rebuild |
| @@ -302,6 +302,9 @@ func (e *PointGetExecutor) get(ctx context.Context, key kv.Key) ([]byte, error) | |||
| func encodeIndexKey(e *baseExecutor, tblInfo *model.TableInfo, idxInfo *model.IndexInfo, idxVals []types.Datum, tID int64) (_ []byte, err error) { | |||
| sc := e.ctx.GetSessionVars().StmtCtx | |||
| for i := range idxVals { | |||
| if idxVals[i].IsNull() { | |||
There was a problem hiding this comment.
If we skip the null value, we built a non exists index key, I think it is not the right way to fix the bug.
There was a problem hiding this comment.
Why does the index key not exist? This loop is used to cast the idxVals to target types, which is unnecessary for null type values.
After casting, all null values will also be encoded into the key.
There was a problem hiding this comment.
But if the index has a null value, it is not encoded as unique index, the rowid is appended to the key.
There was a problem hiding this comment.
I mean we should let the caller know the index value has a null value, we can not point get this key.
There was a problem hiding this comment.
Updated. PTAL @coocood
imtbkcat
added
the
priority/release-blocker
| @@ -313,19 +320,19 @@ func encodeIndexKey(e *baseExecutor, tblInfo *model.TableInfo, idxInfo *model.In | |||
| } else { | |||
| idxVals[i], err = table.CastValue(e.ctx, idxVals[i], colInfo, true, false) | |||
| if types.ErrOverflow.Equal(err) { | |||
| return nil, kv.ErrNotExist | |||
| return nil, false, kv.ErrNotExist | |||
There was a problem hiding this comment.
We could return nil, true, nil, then outer do not need to check kv.ErrNotExist.
There was a problem hiding this comment.
After discussing with @tiancaiamao , I change the argument nonExist to hasNull. PTAL
|
LGTM |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@qw4990 merge failed. |
|
/rebuild |
|
/run-unit-test |
zz-jason
changed the title
in null in point/batch get operatorsin null in point/batch ...
What problem does this PR solve?
Issue Number: close #18839
Problem Summary: resolve errors caused by
in nullin point/batch get operatorsWhat is changed and how it works?
Skip null values when casting.
Check List
Tests
Release note
in nullin point/batch get operators