planner, executor: fix haven't track the memory usage of PointGet/BatchPointGet #21230

zhaoxugang · 2020-11-23T15:47:19Z

fix haven't track the memroy usage of PointGet/BatchPointGet

What problem does this PR solve?

Issue Number: close #21653

Problem Summary:

What is changed and how it works?

What's Changed:
enable memory tracker in point_get/batch_point_get

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Release note

planner, executor: fix haven't track the memroy usage of PointGet/BatchPointGet

…works and enable memory tracker in point_get/batch_point_get

sre-bot · 2020-11-23T15:47:30Z

Please follow PR Title Format:

pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

*: what's changed

sre-bot · 2020-11-23T16:01:03Z

Please follow PR Title Format:

pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

*: what's changed

sre-bot · 2020-11-23T16:35:49Z

Please follow PR Title Format:

pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

*: what's changed

sre-bot · 2020-11-23T16:41:56Z

Please follow PR Title Format:

pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

*: what's changed

zhaoxugang · 2020-11-25T14:17:15Z

PTAL @winoros @wshwsh12

zhaoxugang · 2020-11-25T15:37:21Z

/run-all-tests

wshwsh12

Now we haven't track the memroy usage of PointGet/BatchPointGet. But I think we should use another issue/pr to track it, not this. One pr should only do one thing.

Rest LGTM @zhaoxugang

session/session_test.go

wshwsh12 · 2020-12-10T03:49:21Z

/reward 300

ti-challenge-bot · 2020-12-10T03:49:28Z

This PR's linked issue is not picked.

ti-chi-bot · 2021-02-22T14:28:33Z

Merge canceled because a new commit is pushed.

ti-chi-bot · 2021-02-22T14:28:34Z

@zhaoxugang: Your PR has out-of-dated, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

CLAassistant · 2021-02-22T14:28:42Z

All committers have signed the CLA.

…t-get-member-hint

zz-jason

@zhaoxugang thanks for your contribution, please resolve conflicts and address the comments.

zz-jason · 2021-03-27T12:48:46Z

session/session_test.go

@@ -3161,6 +3161,32 @@ func (s *testSessionSuite2) TestStmtHints(c *C) {
 c.Assert(tk.Se.GetSessionVars().GetReplicaRead(), Equals, kv.ReplicaReadFollower)
 }

+// Test memory track in POINT_GET/BATCH_POINT_GET for issue 21653
+func (s *testSessionSuite2) TestPointGetMemoryTracking(c *C) {


Could you directly validate the tracked memory usage?

Please also add tests for clustered index whose type is not an integer.

I can't directly validate the memory usage,do you have some advices to do it?

In this case, what is the difference between integer and others, why need add tests for clustered index whose type is not an integer.

hawkingrei · 2022-01-23T09:03:45Z

@zhaoxugang Thank you for your contribution. Do you have time to solve the conflicts? If there is no reply within a week, I will close the PR and take over the job.

# Conflicts: # executor/batch_point_get.go # executor/point_get.go

# Conflicts: # executor/point_get.go

zhaoxugang · 2022-02-11T16:21:19Z

/run-check_dev

sre-bot · 2022-02-12T08:12:49Z

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/47e7c0a99de42858f6e789e806e09aae7514ffd7

zhaoxugang · 2022-02-12T09:01:14Z

@zhaoxugang Thank you for your contribution. Do you have time to solve the conflicts? If there is no reply within a week, I will close the PR and take over the job.

done

hawkingrei · 2022-02-12T10:59:07Z

@wshwsh12 PTAL

ti-chi-bot · 2022-05-09T14:29:46Z

@zhaoxugang: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-08-07T08:06:17Z

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.8708%. Comparing base (2ae8529) to head (47e7c0a).
Report is 11671 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #21230         +/-   ##
=================================================
- Coverage   77.1798%   63.8708%   -13.3090%     
=================================================
  Files           588        773        +185     
  Lines        148465     257205     +108740     
=================================================
+ Hits         114585     164279      +49694     
- Misses        23589      79824      +56235     
- Partials      10291      13102       +2811

fix statement-level optimize hint will be ignored when tryFastPlan …

f76abb3

…works and enable memory tracker in point_get/batch_point_get

zhaoxugang requested review from a team as code owners November 23, 2020 15:47

zhaoxugang requested review from wshwsh12 and winoros and removed request for a team November 23, 2020 15:47

ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Nov 23, 2020

fix import,test sql

5c81c3f

github-actions bot added sig/execution SIG execution sig/planner SIG: Planner labels Nov 23, 2020

zhaoxugang changed the title ~~fix statement-level optimize hint will be ignored when tryFastPlan …~~ fix statement-level optimize hint will be ignored when tryFastPlan works Nov 23, 2020

fix error

83f4248

zhaoxugang changed the title ~~fix statement-level optimize hint will be ignored when tryFastPlan works~~ fix statement-level optimize hint invalid and memory tracker when tryFastPlan works Nov 23, 2020

fix unit test

7f58a62

ghost changed the title ~~fix statement-level optimize hint invalid and memory tracker when tryFastPlan works~~ planner, executor: fix statement-level optimize hint invalid and memory tracker when tryFastPlan works Nov 23, 2020

zhaoxugang added 3 commits November 24, 2020 01:19

fix unit test

e4aa904

fix unit test

291e2c6

fix unit test

c9f3966

ichn-hu mentioned this pull request Nov 24, 2020

Welcome to contribute #20804

Closed

wshwsh12 reviewed Dec 10, 2020

View reviewed changes

session/session_test.go Show resolved Hide resolved

zhaoxugang changed the title ~~planner, executor: fix statement-level optimize hint invalid and memory tracker when tryFastPlan works~~ planner, executor: fix haven't track the memroy usage of PointGet/BatchPointGet Dec 11, 2020

ti-chi-bot removed the sig/infra label Feb 22, 2021

Merge branch 'master' into point-get-member-hint

65feff2

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2021

ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 22, 2021

zhaoxugang added 2 commits February 22, 2021 23:07

Merge branch 'master' into point-get-member-hint

279e4c5

Merge remote-tracking branch 'origin/point-get-member-hint' into poin…

1430ee2

…t-get-member-hint

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2021

Merge branch 'master' into point-get-member-hint

ab74f22

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2021

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2021

zz-jason reviewed Mar 27, 2021

View reviewed changes

Merge branch 'master' into point-get-member-hint

f2ae417

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2021

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2021

Merge branch 'master-upstream' into point-get-member-hint

a5fa934

# Conflicts: # executor/batch_point_get.go # executor/point_get.go

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2022

Merge branch 'master-upstream' into point-get-member-hint

7d2359a

# Conflicts: # executor/point_get.go

zhaoxugang added 2 commits February 12, 2022 00:35

format fix

46013d0

fix bug

47e7c0a

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner, executor: fix haven't track the memory usage of PointGet/BatchPointGet #21230

planner, executor: fix haven't track the memory usage of PointGet/BatchPointGet #21230

zhaoxugang commented Nov 23, 2020 •

edited

Loading

sre-bot commented Nov 23, 2020

sre-bot commented Nov 23, 2020

sre-bot commented Nov 23, 2020

sre-bot commented Nov 23, 2020

zhaoxugang commented Nov 25, 2020

zhaoxugang commented Nov 25, 2020

wshwsh12 left a comment •

edited

Loading

wshwsh12 commented Dec 10, 2020

ti-challenge-bot bot commented Dec 10, 2020

ti-chi-bot commented Feb 22, 2021

ti-chi-bot commented Feb 22, 2021

CLAassistant commented Feb 22, 2021 •

edited by sre-bot

Loading

zz-jason left a comment

zz-jason Mar 27, 2021

zhaoxugang Mar 28, 2021

zhaoxugang Apr 3, 2021

hawkingrei commented Jan 23, 2022 •

edited

Loading

zhaoxugang commented Feb 11, 2022

sre-bot commented Feb 12, 2022

zhaoxugang commented Feb 12, 2022

hawkingrei commented Feb 12, 2022

ti-chi-bot commented May 9, 2022

codecov bot commented Aug 7, 2023 •

edited

Loading

planner, executor: fix haven't track the memory usage of PointGet/BatchPointGet #21230

Are you sure you want to change the base?

planner, executor: fix haven't track the memory usage of PointGet/BatchPointGet #21230

Conversation

zhaoxugang commented Nov 23, 2020 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Related changes

Check List

Release note

sre-bot commented Nov 23, 2020

sre-bot commented Nov 23, 2020

sre-bot commented Nov 23, 2020

sre-bot commented Nov 23, 2020

zhaoxugang commented Nov 25, 2020

zhaoxugang commented Nov 25, 2020

wshwsh12 left a comment • edited Loading

Choose a reason for hiding this comment

wshwsh12 commented Dec 10, 2020

ti-challenge-bot bot commented Dec 10, 2020

ti-chi-bot commented Feb 22, 2021

ti-chi-bot commented Feb 22, 2021

CLAassistant commented Feb 22, 2021 • edited by sre-bot Loading

zz-jason left a comment

Choose a reason for hiding this comment

zz-jason Mar 27, 2021

Choose a reason for hiding this comment

zhaoxugang Mar 28, 2021

Choose a reason for hiding this comment

zhaoxugang Apr 3, 2021

Choose a reason for hiding this comment

hawkingrei commented Jan 23, 2022 • edited Loading

zhaoxugang commented Feb 11, 2022

sre-bot commented Feb 12, 2022

zhaoxugang commented Feb 12, 2022

hawkingrei commented Feb 12, 2022

ti-chi-bot commented May 9, 2022

codecov bot commented Aug 7, 2023 • edited Loading

Codecov Report

zhaoxugang commented Nov 23, 2020 •

edited

Loading

wshwsh12 left a comment •

edited

Loading

CLAassistant commented Feb 22, 2021 •

edited by sre-bot

Loading

hawkingrei commented Jan 23, 2022 •

edited

Loading

codecov bot commented Aug 7, 2023 •

edited

Loading