executor: fix a bug that can not insert null into a not null column in the empty SQL mode #21237
+22
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzmhhh123
reviewed
Nov 24, 2020
| tk.MustExec("create table t (id int NOT NULL DEFAULT 8);") | ||
| tk.MustExec("SET sql_mode = '';") | ||
| tk.MustExec("insert into t values (1), (NULL), (2);") | ||
| tk.MustQuery("select * from t").Check(testkit.Rows("1", "0", "2")) |
There was a problem hiding this comment.
Please check the warning for this query.
There was a problem hiding this comment.
insert into t values (1), (NULL), (2);
wjhuang2016
commented
Nov 24, 2020
Closed
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
ti-srebot
approved these changes
Dec 24, 2020
jackysp
added
the
compatibility-breaker
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
|
/merge |
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
|
/run-e2e-test |
|
/merge |
|
/run-all-tests |
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 6, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #27832 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: close #11648
Problem Summary:
What is changed and how it works?
Set BadNullAsWarning to
Trueif not StrictSQLMode.Related changes
Check List
Tests
Side effects
Release note