types: fix return err when decimal from string value

[erwadba]

What problem does this PR solve?

Issue Number: close #22394

Problem Summary:

test> drop table t1;
Query OK, 0 rows affected (0.27 sec)
test> create table t1(id decimal(10));
Query OK, 0 rows affected (0.12 sec)
test> insert into t1 values('1dsf');    
Query OK, 1 row affected (0.03 sec)   <<<<<<<<<<< should report error there
test> 

What is changed and how it works?

What's Changed:
When string value to decimal not meet word e/E. Report ErrTruncated.
How it Works:

Related changes

• Need to cherry-pick to the release branch

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

mysql> create table td(id decimal(10,6));
Query OK, 0 rows affected (0.04 sec)
mysql> insert into td values('1sdf');
ERROR 1366 (HY000): Incorrect decimal value: '1sdf' for column 'id' at row 1
mysql>

Side effects

• N/A

Release note

• No release note

[erwadba]

@wshwsh12 PTAL

[erwadba]

@XuHuaiyu PTAL

[erwadba]

@ti-srebot /run-all-tests

[xiongjiwei]

hi, could you please add the Manual test into your PR?

[erwadba]

@xiongjiwei PTAL
Maybe this pr #22507 already fix this bug. I test in the master branch. It will return error ERROR 8029 (HY000): Bad Number. The test like this below

In TIDB master branch
mysql> create table td(id decimal(10));
Query OK, 0 rows affected (0.04 sec)
mysql> insert into td values('1dsf');
ERROR 8029 (HY000): Bad Number
mysql>

But the pr #22507 didn't consider the situation like below. I test in the master branch.

In TIDB master branch
mysql>  insert into td values('1.1.1.1.1');          <<<< there need report error
Query OK, 1 row affected, 1 warning (0.00 sec)
mysql> show warnings;
+---------+------+------------------------------------------+
| Level   | Code | Message                                  |
+---------+------+------------------------------------------+
| Warning | 1292 | Truncated incorrect DECIMAL value: '1.1' |
+---------+------+------------------------------------------+
1 row in set (0.00 sec)
mysql>

In MySQL8
mysql> insert into td values('1.1.1.1.1');
ERROR 1366 (HY000): Incorrect decimal value: '1.1.1.1.1' for column 'id' at row 1
mysql>

[erwadba]

@AilinKid PTAL

[erwadba]

@lysu PTAL

[AilinKid]

we can add more tests here to simplify the coverage.

eg: for the line you remove in L424, the '12e-3', '12A' should be added. and seems we need a warning for the latter.

[erwadba]

Done. PTAL~ Thx.

[tisonkun]

/cc @AilinKid @xiongjiwei

Conflict resolved, please take a look >_<

[Defined2014]

/cc @xiongjiwei @xhebox @wjhuang2016
PTAL

[xiongjiwei]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 457b905

[wjhuang2016]

/run-check_dev_2