Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: check NotNullFlag of columns when simplifying binary operations #24049

Merged
merged 4 commits into from
Apr 15, 2021
Merged

expression: check NotNullFlag of columns when simplifying binary operations #24049

merged 4 commits into from
Apr 15, 2021

Conversation

eurekaka
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #23891

Problem Summary:

Wrong result of queries.

What is changed and how it works?

What's Changed:

Check NotNullFlag in refineArgs before saying that the result of the expression is exceptional.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Fix wrong query result when column contains null values

@eurekaka eurekaka requested a review from a team as a code owner April 15, 2021 08:48
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 15, 2021
@eurekaka eurekaka requested a review from XuHuaiyu April 15, 2021 08:51
@eurekaka eurekaka added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Apr 15, 2021
@XuHuaiyu
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2021
@eurekaka eurekaka requested a review from a team as a code owner April 15, 2021 09:46
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 15, 2021
time-and-fate
time-and-fate approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2021
@eurekaka
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7e57d02

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@ichn-hu ichn-hu mentioned this pull request Apr 15, 2021
Closed
@Rustin170506
Copy link
Member

/run-check_dev_2

1 similar comment
@Rustin170506
Copy link
Member

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 75a031a into pingcap:master Apr 15, 2021
@ti-srebot ti-srebot mentioned this pull request Apr 15, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24063

@eurekaka eurekaka deleted the refine_null branch April 15, 2021 16:12
eurekaka added a commit to ti-srebot/tidb that referenced this pull request Apr 16, 2021
@eurekaka
cherry pick pingcap#24049 to release-5.0
2bd8b50 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@wshwsh12 wshwsh12 mentioned this pull request Apr 16, 2021
Closed
ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
expression: check NotNullFlag of columns when simplifying binary oper…
83d786b 
…ations (#24049) (#24063)
@Defined2014 Defined2014 mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 priority/release-blocker This issue blocks a release. Please solve it ASAP. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

executor: wrong results for outer join in a case
6 participants
@eurekaka @XuHuaiyu @ti-chi-bot @Rustin170506 @ti-srebot @time-and-fate