Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/stmtsummary: migrate test-infra to testify #26771

Closed
wants to merge 3 commits into from

Conversation

feitian124
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #26420

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 31, 2021
@feitian124
Copy link
Contributor Author

/cc @tisonkun
hi, please help review, thanks

@ti-chi-bot ti-chi-bot requested a review from tisonkun July 31, 2021 11:09
@tisonkun
Copy link
Contributor

tisonkun commented Aug 2, 2021

@feitian124 thanks for your contribution @feitian124 ! I'll review this PR tomorrow.

@feitian124
Copy link
Contributor Author

@tisonkun ok, thanks

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you separate statement_summary_test.go changes into another PR? This PR is too large to review.

@feitian124
Copy link
Contributor Author

sorry, it is large and take me some time to finish...
but i am not sure how to separate them to 2 pr as they solve 1 issue, and if put them in 2 different branch the unit test will fail without aditional work.

i did reorder my commit and pushed to a new branch https://github.com/feitian124/tidb/commits/issue-26420-new,
so statement_summary_test.go is in an separate commit.

commit f01914e8ecf743b3a22edf81a49ed25eb9ac6c7d (HEAD -> issue-26420-new, my/issue-26420-new, issue-26420-part1)
Author: feitian124 <feitian124@gmail.com>
Date:   Tue Aug 3 13:32:11 2021 +0800

    util/stmtsummary: migrate test-infra to testify, part 2

 util/stmtsummary/evicted_test.go   | 143 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------
 util/stmtsummary/main_test.go      |  26 ++++++++++++++++++++++++++
 util/stmtsummary/variables_test.go |  98 +++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------
 3 files changed, 151 insertions(+), 116 deletions(-)

commit 68a3829fefe77aa229af61963710366bfe452120
Author: feitian124 <feitian124@gmail.com>
Date:   Tue Aug 3 13:32:00 2021 +0800

    util/stmtsummary: migrate test-infra to testify, part 1

 util/stmtsummary/statement_summary_test.go | 615 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------------------
 1 file changed, 311 insertions(+), 304 deletions(-)

not sure if this help.
if this is what you want, i can create a new pr based on issue-26420-new and close this pr.
if this is not what you want, please give some guide.
thanks.

@tisonkun
Copy link
Contributor

tisonkun commented Aug 3, 2021

@feitian124 you can take a look at how we do it for domain pkg #26306, or if you separate in multiple commits in one PR said this one, it is fine also.

@tisonkun
Copy link
Contributor

tisonkun commented Aug 3, 2021

Here is an example how to break diff into meaningful commits that helps on reviewing. https://github.com/apache/flink/pull/9832/commits

@feitian124
Copy link
Contributor Author

@feitian124 you can take a look at how we do it for domain pkg #26306, or if you separate in multiple commits in one PR said this one, it is fine also.

hi @tisonkun , i have separate them to 3 pr, hopefully can make your review easier.

@feitian124 feitian124 closed this Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for util/stmtsummary pkg
3 participants