server: migrate packetIO related tests to testify

[yedamao]

What problem does this PR solve?

Issue Number: close #27041

Release note

None.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• tangenta
• xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[tisonkun]

LGTM.

[ti-chi-bot]

@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[tisonkun]

/cc @xhebox @tiancaiamao

PTAL.

[xhebox]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: f822e95

[yedamao]

/run-all-tests

[yedamao]

/run-build

[yedamao]

/run-check_dev_2

[yedamao]

/run-check_dev_2

[yedamao]

database/sql.(*DB).connectionOpener
database/sql.(*Tx).awaitDone
github.com/dgraph-io/ristretto.(*Cache).processItems
github.com/dgraph-io/ristretto.(*defaultPolicy).processItems
github.com/go-sql-driver/mysql.(*mysqlConn).startWatcher.func1
github.com/pingcap/badger.(*DB).runFlushMemTable
github.com/pingcap/badger.(*DB).updateSize
github.com/pingcap/badger.(*blobGCHandler).run
github.com/pingcap/badger.(*levelsController).runWorker
github.com/pingcap/badger.(*writeWorker).runMergeLSM
github.com/pingcap/badger.(*writeWorker).runWriteLSM
github.com/pingcap/badger.(*writeWorker).runWriteVLog
github.com/pingcap/badger.Open.func4
github.com/pingcap/badger/epoch.(*ResourceManager).collectLoop
github.com/pingcap/tidb/ddl.(*ddl).limitDDLJobs
github.com/pingcap/tidb/ddl.(*delRange).startEmulator
github.com/pingcap/tidb/ddl.(*worker).start
github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop.func1
github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop.func1
github.com/pingcap/tidb/domain.(*Domain).TelemetryReportLoop.func1
github.com/pingcap/tidb/domain.(*Domain).TelemetryRotateSubWindowLoop.func1
github.com/pingcap/tidb/domain.(*Domain).globalBindHandleWorkerLoop.func1
github.com/pingcap/tidb/domain.(*Domain).handleEvolvePlanTasksLoop.func1
github.com/pingcap/tidb/domain.(*Domain).infoSyncerKeeper
github.com/pingcap/tidb/domain.(*Domain).topNSlowQueryLoop
github.com/pingcap/tidb/domain.(*Domain).topologySyncerKeeper
github.com/pingcap/tidb/server.(*Server).Run
github.com/pingcap/tidb/server.NewServer.func1
github.com/pingcap/tidb/store/mockstore/unistore/tikv.(*MVCCStore).StartDeadlockDetection.func1
github.com/pingcap/tidb/store/mockstore/unistore/tikv.(*MVCCStore).runUpdateSafePointLoop
github.com/pingcap/tidb/store/mockstore/unistore/tikv.writeDBWorker.run
github.com/pingcap/tidb/store/mockstore/unistore/tikv.writeLockWorker.run
github.com/pingcap/tidb/util/topsql/tracecpu.(*sqlCPUProfiler).startAnalyzeProfileWorker
github.com/soheilhy/cmux.muxListener.Accept
github.com/tikv/client-go/v2/internal/locate.(*RegionCache).asyncCheckAndResolveLoop
github.com/tikv/client-go/v2/oracle/oracles.(*pdOracle).updateTS
github.com/tikv/client-go/v2/tikv.(*KVStore).runSafePointChecker
github.com/tikv/client-go/v2/tikv.(*KVStore).safeTSUpdater
github.com/tikv/client-go/v2/txnkv/transaction.keepAlive
go.etcd.io/etcd/pkg/logutil.(*MergeLogger).outputLoop
go.opencensus.io/stats/view.(*worker).start
gopkg.in/natefinch/lumberjack%2ev2.(*Logger).millRun
internal/poll.runtime_pollWait
net/http.(*persistConn).readLoop
net/http.(*persistConn).writeLoop
time.Sleep

goleak detected too many leaked goroutines, should we ignore them all? @tisonkun

[tisonkun]

@yedamao you can find similar discussion on #26712

I'd additionally share that goleak describes how to locate failure tests, you may try to locate them and see whether we can fix in one round. At least log in the tracking issue of server pkg.

[yedamao]

/run-check_dev_2

[tisonkun]

@xhebox @tangenta would you help on merging this PR?

[yedamao]

I have some trouble with tidbTestSuite.TestGracefulShutdown.

The commit 4d1d72f fixed goroutine leak in TestGracefulShutdown, but it cause tidbTestSuite.TestOnlySocket and tidbTestSuite.TestSocketAndIp not pass. it's weird

On the master branch, run go test for server pkg exclude TestGracefulShutdown
make failpoint-enable && cd server && go test -v --run=TestT -check.exclude=TestGracefulShutdown also failed.

[yedamao]

I'm still digging on this

[yedamao]

/run-check_dev_2

[yedamao]

I have some trouble with tidbTestSuite.TestGracefulShutdown.

The commit 4d1d72f fixed goroutine leak in TestGracefulShutdown, but it cause tidbTestSuite.TestOnlySocket and tidbTestSuite.TestSocketAndIp not pass. it's weird

On the master branch, run go test for server pkg exclude TestGracefulShutdown
make failpoint-enable && cd server && go test -v --run=TestT -check.exclude=TestGracefulShutdown also failed.

I found the problem is in tidbTestSuite.TestInitConnect.

// change the init-connect to invalid.
dbt.mustExec(`SET GLOBAL init_connect="invalidstring"`)

the above operation will set some invalid status to the tidbTestSuite's tidbdrv/store field. cause the other tests failed.

fixed:
Add operation to clean up in TestInitConnect set global init_connect to empty to avoid fail other tests. commit d1dd0da

@tisonkun @xhebox @tangenta PTAL

[xhebox]

Impressive, I think we could merge it now.
/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: d1dd0da

[ti-chi-bot]

@yedamao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.