Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: separate auto_increment ID from row ID #28448

Closed
wants to merge 8 commits into from

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Sep 28, 2021

What problem does this PR solve?

Issue Number: close #982

Problem Summary: before this PR, auto_increment ID and _tidb_rowid share the same key-value. The problem is any action that affects auto_increment column also has an impact on _tidb_rowid. For example,

create table t (a bigint auto_increment unique key);
insert into t values (9223372036854775805); -- MaxInt64-2
insert into t values (1);
Query OK, 0 rows affected (0.00 sec)
Query OK, 0 rows affected (0.00 sec)
ERROR 1467 (HY000): Failed to read auto-increment value from storage engine

The first insert statement forces auto_increment ID rebase to 9223372036854775807. Even if the second insert statement does not trigger auto_increment ID allocation, TiDB throws an "Failed to read" error because the _tidb_rowid allocator is exhausted.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please add a release note, or a 'None' if it is not needed.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 28, 2021
@tangenta tangenta changed the title *: separate auto_increment ID from tidb row id *: separate auto_increment ID from row ID Sep 28, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 28, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Oct 5, 2021

@tangenta please fix conflict and linters complain.

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2021
@ti-chi-bot
Copy link
Member

@tangenta: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2021
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Dec 19, 2023
Copy link

ti-chi-bot bot commented Apr 9, 2024

@tangenta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test fe1ced9 link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 fe1ced9 link true /test check-dev2
pull-integration-ddl-test fe1ced9 link true /test pull-integration-ddl-test
pull-mysql-client-test fe1ced9 link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/check_dev fe1ced9 link true /test check-dev
idc-jenkins-ci-tidb/mysql-test fe1ced9 link true /test mysql-test
idc-jenkins-ci-tidb/build fe1ced9 link true /test build
pull-br-integration-test fe1ced9 link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tisonkun
Copy link
Contributor

tisonkun commented Apr 9, 2024

Long stale and large conflict. Closing to reduce noise.

@tisonkun tisonkun closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiDB should use separated Allocators for the auto_increment column value and the row ID
3 participants