Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: migrate utils_test.go to testify #28941

Merged
merged 5 commits into from
Nov 11, 2021
Merged

executor: migrate utils_test.go to testify #28941

merged 5 commits into from
Nov 11, 2021

Conversation

Yxa2111
Copy link
Contributor

@Yxa2111 Yxa2111 commented Oct 19, 2021

What problem does this PR solve?

Issue Number: close #28625

Problem Summary: migrate test infra to testify

What is changed and how it works?

What's Changed: executor/utils_test.go

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 19, 2021
@CLAassistant
Copy link

CLAassistant commented Oct 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 19, 2021
@ti-chi-bot
Copy link
Member

Welcome @Yxa2111!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@Yxa2111
Copy link
Contributor Author

Yxa2111 commented Oct 20, 2021

/cc @tisonkun please review this pr, thanks!

tisonkun
tisonkun approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

Sorry that I miss this information.

/cc @bb7133

@ti-chi-bot ti-chi-bot requested a review from bb7133 November 11, 2021 00:53
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2021
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d9fa632

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2021
@ti-chi-bot ti-chi-bot merged commit 2bdebed into pingcap:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@disksing disksing disksing approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for utils_test.go
5 participants
@Yxa2111 @ti-chi-bot @CLAassistant @disksing @tisonkun