planner: allow refineArgs for plan cache in some situations (#28944) #29422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #28944 to release-5.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/29422
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #28858
Problem Summary:
If we forbid the
refineArgs
for plan cache. Thestring <cmp> int
will get an wrong answer. Because when we convert the string to double, it will lose precision.What is changed and how it works?
refineArgs
for plan cache in some situations. And forbid some plans to cache.Check List
Tests
Side effects
Documentation
Release note