Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: migrate test-infra to testify for executor/prepared_test.go #29861

Merged
merged 5 commits into from
Nov 18, 2021
Merged

*: migrate test-infra to testify for executor/prepared_test.go #29861

merged 5 commits into from
Nov 18, 2021

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 17, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #28603

Problem Summary:

What is changed and how it works?

migrate test-infra to testify for prepared_test.go

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 17, 2021
@hawkingrei hawkingrei force-pushed the executor_test branch 4 times, most recently from 41a1269 to d5249ef Compare November 17, 2021 07:54
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 17, 2021
@hawkingrei
Copy link
Member Author

/run-check_dev_2

@hawkingrei hawkingrei force-pushed the executor_test branch 4 times, most recently from 058d4d4 to 9e6a4a3 Compare November 17, 2021 09:09
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2021
@hawkingrei
Copy link
Member Author

@tisonkun @time-and-fate @qw4990 PTAL

@hawkingrei
Copy link
Member Author

/cc @tisonkun @time-and-fate @qw4990

@hawkingrei
*: migrate test-infra to testify for prepared_test.go
4ba964f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
executor: move serial test to prepared_serial_test.go
c65e596 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
executor: move serial test to prepared_serial_test.go
bd82c99 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei changed the title *: migrate test-infra to testify for prepared_test.go *: migrate test-infra to testify for executor/prepared_test.go Nov 17, 2021
@qw4990 qw4990 requested a review from Reminiscent November 18, 2021 06:08
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2021
@hawkingrei
Copy link
Member Author

@time-and-fate @tisonkun @Reminiscent PTAL

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 18, 2021
@rebelice
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bd82c99

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2021
@ti-chi-bot
Copy link
Member

@hawkingrei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 62b07a6 into pingcap:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate left review comments

@rebelice rebelice rebelice approved these changes

@qw4990 qw4990 qw4990 approved these changes

@tisonkun tisonkun Awaiting requested review from tisonkun

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for prepared_test.go
5 participants
@hawkingrei @ti-chi-bot @rebelice @qw4990 @time-and-fate