Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpp: Fix the crash or error when mpp generate empty task list. (#31658) #31697

Merged
merged 2 commits into from
Jan 14, 2022
Merged

mpp: Fix the crash or error when mpp generate empty task list. (#31658) #31697

merged 2 commits into from
Jan 14, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 14, 2022 •
edited
Loading

cherry-pick #31658 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/31697

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/31697:release-5.4-f1f92302642f

What problem does this PR solve?

Issue Number: close #31636

Problem Summary: apply may generate an empty range list, and then generate an empty mpp task list, but we don't handle it correctly.

What is changed and how it works?

handle the situation when mpp task list is empty.

Check List

Tests

  • Unit test
  • Integration test
    need add the original case to our intergration cases

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the crash or error when generating an empty mpp task list.

@LittleFall @ti-srebot
cherry pick pingcap#31658 to release-5.4
d2d729a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 14, 2022
@ti-srebot ti-srebot mentioned this pull request Jan 14, 2022
Merged
10 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.4-cherry-pick labels Jan 14, 2022
@ti-srebot
Copy link
Contributor Author

@LittleFall you're already a collaborator in bot's repo.

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 14, 2022
@LittleFall
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@LittleFall: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

windtalker
windtalker approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 14, 2022
@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e0c5ffe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 14, 2022
@ti-chi-bot ti-chi-bot merged commit ed1cd2a into pingcap:release-5.4 Jan 14, 2022
@LittleFall LittleFall deleted the release-5.4-f1f92302642f branch January 14, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@LittleFall LittleFall LittleFall approved these changes

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees

@LittleFall LittleFall

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.4-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @ti-chi-bot @LittleFall @windtalker @zhouqiang-cl