lightning: maintain task meta in singleTaskMetaMgr

[sleepymole]

What problem does this PR solve?

Issue Number: close #34213

Problem Summary:

Lightning precheck doesn't check local disk resources and cluster available.

What is changed and how it works?

When incremental-import is set to false, Lightning doesn't create a metadata schema in downstream TiDB. Instead, it creates a singleTaskMetaMgr to maintain task metadata. However, singleTaskMetaMgr always returns true for task existence check.

tidb/br/pkg/lightning/restore/meta_manager.go

Line 1088 in 9fc73ac

return true, nil

Precheck for local disk resources and cluster available are accidentally skipped. Because lightning thinks the check has been performed before.

tidb/br/pkg/lightning/restore/restore.go

Line 1923 in 9fc73ac

taskExist, err = rc.taskMgr.CheckTaskExist(ctx)

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that Lightning precheck doesn't check local disk resources and cluster available.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• D3Hunter
• glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1beef9389f69429d5537850b136bee547965dc3f

[sleepymole]

/run-integration-br-test

[D3Hunter]

rest lgtm

[buchuitoudegou]

lgtm

[ti-chi-bot]

@buchuitoudegou: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[sleepymole]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 5834c9f

[purelind]

/run-build

[purelind]

/run-build

[purelind]

/run-all-tests

[purelind]

/run-build

[sleepymole]

/run-integration-br-test

[sleepymole]

/hold

Wait for the integration-br-test to pass.

[sleepymole]

/unhold

All tests are passed.
https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/11342/pipeline/1612/

[sleepymole]

/run-mysql-test

[ti-srebot]

cherry pick to release-5.3 in PR #34225

[ti-srebot]

cherry pick to release-5.4 in PR #34226

[sre-bot]

TiDB MergeCI notify

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci-tidb/tics-test	🟢 all 1 tests passed	1 hr 2 min	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2	🟢 all 28 tests passed	14 min	Existing passed
idc-jenkins-ci-tidb/integration-common-test	🟢 all 11 tests passed	14 min	Existing passed
idc-jenkins-ci-tidb/common-test	🟢 all 12 tests passed	11 min	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1	🟢 all 26 tests passed	10 min	Existing passed
idc-jenkins-ci-tidb/integration-ddl-test	🟢 all 6 tests passed	9 min 42 sec	Existing passed
idc-jenkins-ci-tidb/mybatis-test	🟢 all 1 tests passed	4 min 10 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	3 min 47 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed

[ti-srebot]

cherry pick to release-6.0 in PR #34229