From 5870ef3211085d6fbb9a2a831e7344599f436da9 Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Thu, 14 Jul 2022 23:42:03 +0800 Subject: [PATCH 1/2] use go 1.19rc2 Signed-off-by: Weizhen Wang --- WORKSPACE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WORKSPACE b/WORKSPACE index 744ef2aed9801..f95edb1a9fd43 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -33,7 +33,7 @@ go_rules_dependencies() go_register_toolchains( nogo = "@//build:tidb_nogo", - version = "1.18.5", + version = "1.19", ) gazelle_dependencies() From ca555615c668aa3af8c736e802a2e218d66111b5 Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Thu, 25 Aug 2022 18:43:00 +0800 Subject: [PATCH 2/2] update --- br/pkg/restore/tiflashrec/tiflash_recorder.go | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/br/pkg/restore/tiflashrec/tiflash_recorder.go b/br/pkg/restore/tiflashrec/tiflash_recorder.go index d575a26c17a93..31dde982a7b69 100644 --- a/br/pkg/restore/tiflashrec/tiflash_recorder.go +++ b/br/pkg/restore/tiflashrec/tiflash_recorder.go @@ -32,15 +32,15 @@ import ( // during restoring. // Because the limit of the current implementation, we add serval hooks // to observe the information we need: -// - Before full restore create tables: -// We record the tiflash replica information and remove the replica info. -// Because during PiTR restore, the transaction model would be broken, which breaks TiFlash too. -// We must make sure they won't be replicated to TiFlash during the whole PiTR procedure. -// - After full restore created tables, generating rewrite rules: -// We perform the rewrite rule over our records. -// We trace table via table ID instead of table name so we can handle `RENAME` DDLs. -// - When doing PiTR restore, after rewriting table info in meta key: -// We update the replica information +// - Before full restore create tables: +// We record the tiflash replica information and remove the replica info. +// Because during PiTR restore, the transaction model would be broken, which breaks TiFlash too. +// We must make sure they won't be replicated to TiFlash during the whole PiTR procedure. +// - After full restore created tables, generating rewrite rules: +// We perform the rewrite rule over our records. +// We trace table via table ID instead of table name so we can handle `RENAME` DDLs. +// - When doing PiTR restore, after rewriting table info in meta key: +// We update the replica information type TiFlashRecorder struct { // Table ID -> TiFlash Count items map[int64]model.TiFlashReplicaInfo