Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: refactor json path syntax and make it compatible with mysql #37074

Merged
merged 7 commits into from
Aug 23, 2022
Merged

expression: refactor json path syntax and make it compatible with mysql #37074

merged 7 commits into from
Aug 23, 2022

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Aug 12, 2022 •
edited
Loading

Signed-off-by: xiongjiwei xiongjiwei1996@outlook.com

What problem does this PR solve?

Issue Number: ref #37133
ref #22525
close #34959

syntax ref https://dev.mysql.com/doc/refman/8.0/en/json.html#json-path-syntax

fix the json path syntax compatibility issue with MySQL and make parse json path faster

before:  1000000              1214 ns/op
after:   2808260               367.5 ns/op

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

report error if json path has the wrong syntax.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-linked-issue labels Aug 12, 2022
YangKeao
YangKeao approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@YangKeao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

xhebox
xhebox reviewed Aug 22, 2022
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

types/json/path_expr.go Show resolved Hide resolved
types/json/path_expr.go Show resolved Hide resolved
types/json/path_expr.go Outdated Show resolved Hide resolved
xhebox
xhebox approved these changes Aug 22, 2022
View reviewed changes
types/json/path_expr.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 22, 2022
@xiongjiwei
Copy link
Contributor Author

/run-check_dev

@xiongjiwei
Copy link
Contributor Author

/run-build

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 22, 2022
@xiongjiwei
Copy link
Contributor Author

/run-build

@xiongjiwei
json path
91cc326 
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@xiongjiwei
add test
60f99fa 
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@xiongjiwei
add more test and fix error message
ee7a454 
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@xiongjiwei
refactor incAsLongAs
a170220 
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@xiongjiwei
remove incAsLongAs
c646651 
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@xiongjiwei
make linter happy
9ff1307 
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@hawkingrei
Copy link
Member

/run-mysql-test tidb-test=pr/1926

1 similar comment
@xiongjiwei
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1926

@xhebox
Copy link
Contributor

xhebox commented Aug 23, 2022

/merge
/run-mysql-test tidb-test=pr/1926

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9ff1307

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2022
@xiongjiwei
Copy link
Contributor Author

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit cf69205 into pingcap:master Aug 23, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 23, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 52 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 20 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 33 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 41 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 22 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@xiongjiwei xiongjiwei deleted the json-path branch September 23, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@YangKeao YangKeao YangKeao approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
6 participants
@xiongjiwei @ti-chi-bot @sre-bot @hawkingrei @xhebox @YangKeao