ddl: Support flashback schema #37438

erwadba · 2022-08-29T07:01:14Z

What problem does this PR solve?

Issue Number: close #20463

Problem Summary:

What is changed and how it works?

1.Add RecoverSchemaInfo struct contains SchemaInfo and TableInfo.
2.Add recoverSchema code logical like the recovertable .

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

mysql> drop database m;
Query OK, 0 rows affected (0.43 sec)
mysql> create database m;
Query OK, 0 rows affected (0.20 sec)
mysql> use m;
Database changed
mysql> CREATE TABLE t(id int PRIMARY KEY AUTO_INCREMENT, c int);
Query OK, 0 rows affected (0.19 sec)
mysql> INSERT INTO t(c) VALUES (1);
Query OK, 1 row affected (0.03 sec)
mysql> INSERT INTO t(c) VALUES (2);
Query OK, 1 row affected (0.01 sec)
mysql> drop database m;
Query OK, 0 rows affected (0.42 sec)
mysql> flashback database m;
Query OK, 0 rows affected (0.97 sec)
mysql> use m ;
Database changed
mysql> select * from t;
+----+------+
| id | c    |
+----+------+
|  1 |    1 |
|  2 |    2 |
+----+------+
2 rows in set (0.01 sec)
mysql>

Side effects

N/A

Documentation

N/A

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add support `flashback database` command.

ti-chi-bot · 2022-08-29T07:01:16Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Defined2014
xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

sre-bot · 2022-08-29T07:01:23Z

All committers have signed the CLA.

ti-chi-bot · 2022-08-29T07:24:42Z

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/28ba8e5e344e6264a27d373f19fecdd022aa3494

bb7133 · 2022-08-31T03:15:54Z

ddl/schematracker/checker.go

+// RecoverSchema implements the DDL interface.
+func (d Checker) RecoverSchema(ctx sessionctx.Context, recoverSchemaInfo *ddl.RecoverSchemaInfo) (err error) {
+ //TODO implement me
+ panic("implement me")


@lance6716 Could you give some descriptions/suggestions on the semantic of RecoverSchema of Checker/SchemaTracker?

I can see that some tools integration tests failed because of this: https://github.com/pingcap/tidb/runs/8089302161

Can return nil. Because SchemaTracker is used to track MySQL DDL, and MySQL will not generate RecoverSchema.

Dumpling tests have started to fail several days ago, not related to Checker/SchemaTracker

Dumpling tests have started to fail several days ago, not related to Checker/SchemaTracker

Got it, thanks for the update.

ddl/table.go

ddl/schematracker/checker.go

bb7133 · 2022-10-09T15:10:38Z

ddl/schema.go

+ recoverSchemaInfo *RecoverSchemaInfo
+ recoverSchemaCheckFlag int64
+ )
+ const checkFlagIndexInJobArgs = 1 // The index of `recoverSchemaCheckFlag` in job arg list.


Please change it to global level so that it could be shared by different functions(like this one and onRecoverTable).

Done. PTAL ,Thx~

Defined2014 · 2022-10-13T07:23:52Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.✅ erwadba✅ Defined2014❌ root

root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@erwadba Seems had some root related commits, maybe you could rebase this PR and update the commit author.

maybe could use script below

git filter-branch --force --env-filter '
if [ "$GIT_AUTHOR_NAME" = "root" ]
then
export GIT_AUTHOR_NAME="erwadba"
export GIT_AUTHOR_EMAIL="erwadba@hotmail.com"
fi
' 826c15c8..HEAD

bb7133

LGTM

…al name.

Signed-off-by: xhe <xw897002528@gmail.com>

xhebox · 2022-10-19T05:53:59Z

/merge

ti-chi-bot · 2022-10-19T05:54:03Z

This pull request has been accepted and is ready to merge.

Commit hash: 25e0bc4

Defined2014 · 2022-10-19T06:47:36Z

/run-build

Defined2014 · 2022-10-19T06:47:44Z

/run-unit-test

Defined2014 · 2022-11-01T05:54:13Z

Hi @erwadba, could you add a doc for this feature, just like https://docs.pingcap.com/zh/tidb/stable/sql-statement-flashback-table#flashback-table do.

ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 29, 2022

ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 29, 2022

erwadba mentioned this pull request Aug 29, 2022

*: add function flashback database #30217

Merged

3 tasks

xhebox self-requested a review August 29, 2022 07:54

erwadba force-pushed the support_flashback_schema branch from a7e8013 to 4c91ac1 Compare August 30, 2022 09:54

bb7133 reviewed Aug 31, 2022

View reviewed changes

bb7133 reviewed Sep 1, 2022

View reviewed changes

ddl/table.go Show resolved Hide resolved

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2022

erwadba force-pushed the support_flashback_schema branch from 28ba8e5 to f3e9324 Compare September 2, 2022 02:11

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2022

bb7133 reviewed Sep 2, 2022

View reviewed changes

ddl/schematracker/checker.go Outdated Show resolved Hide resolved

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2022

xhebox approved these changes Sep 7, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2022

bb7133 reviewed Oct 9, 2022

View reviewed changes

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2022

Defined2014 approved these changes Oct 13, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 13, 2022

bb7133 approved these changes Oct 19, 2022

View reviewed changes

erwadba added 6 commits October 19, 2022 13:45

Suppot flashback database grammar

6cee1ea

Support flashback database

11ac095

fix test case error

d548bbb

fix error: when exec flashback database,gc not work.

542d41b

change onRecoverTable code use recoverTable

4053385

fix test case

7f2be90

erwadba and others added 4 commits October 19, 2022 13:45

Add check newname when flashback table.Avoid flashback table to illeg…

005c3c5

…al name.

change onRecoverTable code use recoverTable

d7c6bd1

change const value to global level

c15387e

rebase and fix author

25e0bc4

Signed-off-by: xhe <xw897002528@gmail.com>

xhebox force-pushed the support_flashback_schema branch from e247e9d to 25e0bc4 Compare October 19, 2022 05:53

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2022

Merge branch 'master' into support_flashback_schema

5d7f2d7

ti-chi-bot merged commit 300d9e7 into pingcap:master Oct 19, 2022

erwadba deleted the support_flashback_schema branch February 22, 2023 05:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddl: Support flashback schema #37438

ddl: Support flashback schema #37438

erwadba commented Aug 29, 2022 •

edited by bb7133

Loading

ti-chi-bot commented Aug 29, 2022 •

edited

Loading

sre-bot commented Aug 29, 2022 •

edited

Loading

ti-chi-bot commented Aug 29, 2022 •

edited

Loading

bb7133 Aug 31, 2022

lance6716 Aug 31, 2022

lance6716 Aug 31, 2022

bb7133 Aug 31, 2022

bb7133 Oct 9, 2022

erwadba Oct 10, 2022

Defined2014 commented Oct 13, 2022 •

edited

Loading

bb7133 left a comment

xhebox commented Oct 19, 2022

ti-chi-bot commented Oct 19, 2022

Defined2014 commented Oct 19, 2022

Defined2014 commented Oct 19, 2022

Defined2014 commented Nov 1, 2022

ddl: Support flashback schema #37438

ddl: Support flashback schema #37438

Conversation

erwadba commented Aug 29, 2022 • edited by bb7133 Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Aug 29, 2022 • edited Loading

sre-bot commented Aug 29, 2022 • edited Loading

ti-chi-bot commented Aug 29, 2022 • edited Loading

bb7133 Aug 31, 2022

Choose a reason for hiding this comment

lance6716 Aug 31, 2022

Choose a reason for hiding this comment

lance6716 Aug 31, 2022

Choose a reason for hiding this comment

bb7133 Aug 31, 2022

Choose a reason for hiding this comment

bb7133 Oct 9, 2022

Choose a reason for hiding this comment

erwadba Oct 10, 2022

Choose a reason for hiding this comment

Defined2014 commented Oct 13, 2022 • edited Loading

bb7133 left a comment

Choose a reason for hiding this comment

xhebox commented Oct 19, 2022

ti-chi-bot commented Oct 19, 2022

Defined2014 commented Oct 19, 2022

Defined2014 commented Oct 19, 2022

Defined2014 commented Nov 1, 2022

erwadba commented Aug 29, 2022 •

edited by bb7133

Loading

ti-chi-bot commented Aug 29, 2022 •

edited

Loading

sre-bot commented Aug 29, 2022 •

edited

Loading

ti-chi-bot commented Aug 29, 2022 •

edited

Loading

Defined2014 commented Oct 13, 2022 •

edited

Loading