lightning: make default file router support compression #38515
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
br/pkg/lightning/mydump/router.go
Outdated
| // source file pattern, matches files like '{schema}.{table}.0001.{sql|csv}' | ||
| {Pattern: `(?i)^(?:[^/]*/)*([^/.]+)\.(.*?)(?:\.([0-9]+))?\.(sql|csv|parquet)$`, Schema: "$1", Table: "$2", Type: "$4", Key: "$3", Unescape: true}, | ||
| {Pattern: `(?i).*(-schema-trigger|-schema-post)\.sql(?:\.(\w*?))$`, Type: "ignore"}, | ||
| // db schema create file pattern, matches files like '{schema}-schema-create.sql{.compress}' |
There was a problem hiding this comment.
| // db schema create file pattern, matches files like '{schema}-schema-create.sql{.compress}' | |
| // db schema create file pattern, matches files like '{schema}-schema-create.sql.{compress}' |
There was a problem hiding this comment.
How about this? I want to express that this compress suffix (including the dot '.') is optional.
| // db schema create file pattern, matches files like '{schema}-schema-create.sql{.compress}' | |
| // db schema create file pattern, matches files like '{schema}-schema-create.sql(.compress)' |
There was a problem hiding this comment.
I now prefer {schema}-schema-create.sql[.{compress}]
|
@lyzx2001: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ti-chi-bot
added
status/LGT2
|
/run-br-integration-tests |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 367936c
|
ti-chi-bot
added
the
status/can-merge
|
/run-integration-br-test |
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: ref #38514
Problem Summary:
What is changed and how it works?
Implement two tasks in compress lightning
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.