Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Add support for ALTER TABLE t PARTITION BY ... | tidb-test=pr/2112 #42882

Closed
wants to merge 4 commits into from
Closed

*: Add support for ALTER TABLE t PARTITION BY ... | tidb-test=pr/2112 #42882

wants to merge 4 commits into from

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Apr 10, 2023

What problem does this PR solve?

Issue Number: ref #42728

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add support for (re)partition a table with ALTER TABLE t PARTITION BY ...

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 10, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Apr 10, 2023

/test all

@mjonss
Copy link
Contributor Author

mjonss commented Apr 10, 2023

/retest

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 10, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Apr 10, 2023

/retest

@mjonss mjonss changed the title *: Add support for ALTER TABLE t PARTITION BY ... *: Add support for ALTER TABLE t PARTITION BY ... | tidb-test=pr/2112 Apr 10, 2023
@mjonss mjonss marked this pull request as ready for review April 10, 2023 20:47
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2023
bb7133
bb7133 reviewed Apr 12, 2023
View reviewed changes
ddl/ddl_api.go
meta.Partition = piOld
partNames = append(partNames, piOld.Definitions[0].Name)
}
newMeta := meta.Clone()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta is either cloned from t.Meta() or generated by getPartitionInfoTypeNone(), do we need to clone it again?

@ti-chi-bot
Copy link
Member

@mjonss: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 592ad80 link true /test unit-test
idc-jenkins-ci-tidb/build 545a313 link true /test build
idc-jenkins-ci-tidb/check_dev 545a313 link true /test check-dev
idc-jenkins-ci-tidb/mysql-test cb3020b link true /test mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2023
@ti-chi-bot
Copy link
Member

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjonss
Copy link
Contributor Author

mjonss commented May 8, 2023

This is now a part of #42907.

@mjonss mjonss closed this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjonss @ti-chi-bot @bb7133