Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix correctness of the correlated predicate push down for cte | tidb-test=pr/2128 #43759

Merged
merged 2 commits into from
May 13, 2023
Merged

planner: fix correctness of the correlated predicate push down for cte | tidb-test=pr/2128 #43759

merged 2 commits into from
May 13, 2023

Conversation

winoros
Copy link
Member

@winoros winoros commented May 12, 2023

What problem does this PR solve?

Issue Number: close #43645

Problem Summary:

The predicate push-down might change the correlated status of the CTE. Our current implementation will cause the wrong result.

What is changed and how it works?

We disable that case's pushing down first.
I will support it later.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that pushing the correlated filter into CTE might cause the wrong result.

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels May 12, 2023
@wuhuizuo
Copy link
Contributor

/retest

1 similar comment
@chrysan
Copy link
Contributor

chrysan commented May 12, 2023

/retest

time-and-fate
time-and-fate approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for this PR.
But I think maybe we need to check if there are other bugs when pushing expressions with correlated columns into CTE, especially when there are multiple readers of this CTE.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 12, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2023
@winoros winoros changed the title planner: fix correctness of the correlated predicate push down for cte planner: fix correctness of the correlated predicate push down for cte | tidb-test=pr/2128 May 13, 2023
@winoros
Copy link
Member Author

winoros commented May 13, 2023

/retest

@winoros
Copy link
Member Author

winoros commented May 13, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 13, 2023

This pull request has been accepted and is ready to merge.

Commit hash: bd8327e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit 6caadca into pingcap:master May 13, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #43790.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 13, 2023
@winoros @ti-chi-bot
This is an automated cherry-pick of pingcap#43759
c488cf2 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43791.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 13, 2023
@winoros @ti-chi-bot
This is an automated cherry-pick of pingcap#43759
196d65c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@winoros winoros deleted the fix-correlated-filter-push-down-cte branch May 13, 2023 18:41
winoros added a commit to winoros/tidb that referenced this pull request May 15, 2023
@winoros
planner: fix correctness of the correlated predicate push down for cte (
4fcbf95 
pingcap#43759)

close pingcap#43645
@winoros winoros mentioned this pull request May 15, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request May 18, 2023
@ti-chi-bot
planner: fix correctness of the correlated predicate push down for cte (
c541da7 
#43759) (#43791)

close #43645
ti-chi-bot bot pushed a commit that referenced this pull request May 31, 2023
@ti-chi-bot
planner: fix correctness of the correlated predicate push down for cte (
a962a6d 
#43759) (#43790)

close #43645
winoros pushed a commit to winoros/tidb that referenced this pull request May 31, 2023
@ti-chi-bot @winoros
planner: fix correctness of the correlated predicate push down for cte (
c7d1f4b 
pingcap#43759) (pingcap#43790)

close pingcap#43645
@winoros winoros mentioned this pull request May 31, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request May 31, 2023
@winoros
planner: cherry pick two CTE related commit (#44306)
064a4e5 
ref #43759, ref #44054
@YangKeao YangKeao added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 26, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 26, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #44946.

YangKeao pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 30, 2023
@winoros
This is an automated cherry-pick of pingcap#43759
975c248 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Jun 30, 2023
@ti-chi-bot
planner: fix correctness of the correlated predicate push down for cte (
9a3a7bf 
#43759) (#44946)

close #43645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong result when update multiple columns with CTE
7 participants
@winoros @wuhuizuo @chrysan @ti-chi-bot @wjhuang2016 @time-and-fate @YangKeao