Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Make DDL unaffected by killing TiDB instance #43871

Merged
merged 2 commits into from
May 17, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented May 16, 2023

What problem does this PR solve?

Issue Number: close #43854

Problem Summary:

  1. This issue support canceling DDL statements with KILL(related PR:*: fix a data race on TestConnExecutionTimeout #35923).
    ---The original PR that supported this didn't seem to say cancel DDL on "kill TiDB"

  2. But after these PRs, when we do kill TiDB, this TiDB's DDLs may be canceled(In some cases it can't be cancelled).
    --- Cancel DDL is not fully supported in the case of "kill TiDB".

  3. This issue need do "Pause user DDL when upgrading TiDB", but these DDLs may be canceled by kill TiDB. So we consider kill TiDB can not cancel DDL.

  4. We'll deal with this in detail when we distinguish between asynchronous and synchronous DDLs.

What is changed and how it works?

If don't we kill TiDB can't cancel DDLs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Make DDL unaffected by the KILL TiDB command"

@zimulala zimulala requested a review from a team as a code owner May 16, 2023 08:10
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 16, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels May 16, 2023
@zimulala
Copy link
Contributor Author

PTAL @tiancaiamao

@zimulala zimulala requested a review from tiancaiamao May 16, 2023 08:16
@zimulala zimulala changed the title *: support 'kill TiDB' can't cancel DDLs *: support 'kill TiDB' can't do 'cancel DDL' operation May 16, 2023
@zimulala zimulala changed the title *: support 'kill TiDB' can't do 'cancel DDL' operation *: Make DDL unaffected by the KILL TiDB command" May 16, 2023
@tangenta tangenta changed the title *: Make DDL unaffected by the KILL TiDB command" *: Make DDL unaffected by KILL TiDB May 16, 2023
@zimulala
Copy link
Contributor Author

/retest-required

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2023
@zimulala
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2023

This pull request has been accepted and is ready to merge.

Commit hash: a509ee1

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2023
@tangenta tangenta changed the title *: Make DDL unaffected by KILL TiDB *: Make DDL unaffected by killing TiDB instance May 17, 2023
@zimulala zimulala merged commit 8ae3cac into pingcap:master May 17, 2023
@zimulala zimulala deleted the zimuxia/test branch May 17, 2023 08:32
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43910.

@bb7133 bb7133 added the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kill TiDB can not support cancel DDL
6 participants