From 3719960d02ed35e9294e59b3a6cb98b01257d403 Mon Sep 17 00:00:00 2001 From: BornChanger Date: Mon, 14 Aug 2023 18:26:10 +0800 Subject: [PATCH] br: avoid possible infinite loop checking tikv gc and scheduling status Signed-off-by: BornChanger --- br/pkg/task/backup_ebs.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/br/pkg/task/backup_ebs.go b/br/pkg/task/backup_ebs.go index 38b7daff4f17b..e84fb66188e49 100644 --- a/br/pkg/task/backup_ebs.go +++ b/br/pkg/task/backup_ebs.go @@ -295,13 +295,13 @@ func waitAllScheduleStoppedAndNoRegionHole(ctx context.Context, cfg Config, mgr } else { log.Warn("failed to wait schedule, will retry later", zap.Error(err2)) } - continue - } - - log.Info("all leader regions got, start checking hole", zap.Int("len", len(allRegions))) + } else { + log.Info("all leader regions got, start checking hole", zap.Int("len", len(allRegions))) - if !isRegionsHasHole(allRegions) { - return nil + if !isRegionsHasHole(allRegions) { + return nil + } + log.Info("Regions has hole, needs sleep and retry") } time.Sleep(backoffer.ExponentialBackoff()) }