Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fixing wrong result after applying predicate push down for CTEs (#47891) #48192

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #47891

What problem does this PR solve?

Issue Number: close #47881

Problem Summary:

What is changed and how it works?

The outerMost should be prop of the CTE itself, not the CTE reader's.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that TiDB may push wrong predicates into the CTE.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 1, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 2, 2023
@winoros winoros force-pushed the cherry-pick-47891-to-release-6.5 branch from e2f81a1 to 1b97e30 Compare November 10, 2023 13:44
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 10, 2023
@winoros
Copy link
Member

winoros commented Nov 10, 2023

/retest

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@b7f909c). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #48192   +/-   ##
================================================
  Coverage               ?   73.8910%           
================================================
  Files                  ?       1087           
  Lines                  ?     351650           
  Branches               ?          0           
================================================
  Hits                   ?     259838           
  Misses                 ?      75374           
  Partials               ?      16438           

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 24, 2023
Copy link

ti-chi-bot bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 24, 2023
Copy link

ti-chi-bot bot commented Nov 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-24 06:29:09.65876154 +0000 UTC m=+558578.323987738: ☑️ agreed by time-and-fate.
  • 2023-11-24 06:31:17.801631946 +0000 UTC m=+558706.466858164: ☑️ agreed by AilinKid.

@winoros
Copy link
Member

winoros commented Nov 24, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit a495716 into pingcap:release-6.5 Nov 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants