Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix the issue that plan cache may return wrong result when comparing datetime column with unix_timestamp #48413

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Nov 8, 2023

What problem does this PR solve?

Issue Number: close #48165

Problem Summary: planner: fix the issue that plan cache may return wrong result when comparing datetime column with unix_timestamp

What is changed and how it works?

planner: fix the issue that plan cache may return wrong result when comparing datetime column with unix_timestamp

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2023
Copy link

tiprow bot commented Nov 8, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #48413 (b9c65f3) into master (14ff60d) will increase coverage by 1.7584%.
Report is 14 commits behind head on master.
The diff coverage is 76.6666%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48413        +/-   ##
================================================
+ Coverage   71.3962%   73.1546%   +1.7584%     
================================================
  Files          1402       1425        +23     
  Lines        406845     416773      +9928     
================================================
+ Hits         290472     304889     +14417     
+ Misses        96433      93064      -3369     
+ Partials      19940      18820      -1120     
Flag Coverage Δ
integration 43.9561% <66.6666%> (?)
unit 71.8210% <76.6666%> (+0.4247%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.6580% <ø> (-4.3259%) ⬇️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 8, 2023
Copy link

ti-chi-bot bot commented Nov 8, 2023

@AilinKid: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 8, 2023
Copy link

ti-chi-bot bot commented Nov 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-08 11:40:28.998626389 +0000 UTC m=+3644426.585736534: ☑️ agreed by AilinKid.
  • 2023-11-08 12:28:00.274972004 +0000 UTC m=+3647277.862082150: ☑️ agreed by hawkingrei.

Copy link

ti-chi-bot bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 8, 2023
@ti-chi-bot ti-chi-bot bot merged commit 184aa7e into pingcap:master Nov 8, 2023
13 of 16 checks passed
@qw4990 qw4990 added needs-cherry-pick-release-7.4 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Nov 9, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #48455.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #48456.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 9, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 9, 2023
…omparing datetime column with `unix_timestamp` (#48413) (#48455)

close #48165
@qw4990 qw4990 added the type/bugfix This PR fixes a bug. label Mar 16, 2024
@qw4990
Copy link
Contributor Author

qw4990 commented May 14, 2024

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@qw4990: new pull request created to branch release-7.1: #53263.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 14, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request May 14, 2024
…omparing datetime column with unix_timestamp (#48413) (#53266)

close #41918, close #48165
@qw4990
Copy link
Contributor Author

qw4990 commented May 21, 2024

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@qw4990: new pull request created to branch release-7.5: #53430.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.4 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some result is incorrect when plan cache enabled
5 participants