Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_backup: added more info for slow regions in log backup advancer (#51137) #51175

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51137

What problem does this PR solve?

Issue Number: close #51046

Problem Summary:
It is painful for debugging slow regions in log backup for now. Exactly when there are many TiKV nodes in the cluster: we only have a range but know nothing about which region this key belongs to.
Also we must pick the TiDB log (which isn't always easily accessible.) for such information.

What changed and how does it work?

This PR added two new series to the log backup advancer, which presents the current slowest region's leader location and its region id.
Also we will append more detailed hints about the slowest range.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    A simple log:
    CleanShot 2024-02-19 at 14 20 11@2x
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 20, 2024
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Feb 20, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 20, 2024
Signed-off-by: Yu Juncen <yu745514916@live.com>
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@b4af8ff). Click here to learn what that means.
The diff coverage is 67.5000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #51175   +/-   ##
================================================
  Coverage               ?   73.5865%           
================================================
  Files                  ?       1209           
  Lines                  ?     380094           
  Branches               ?          0           
================================================
  Hits                   ?     279698           
  Misses                 ?      82699           
  Partials               ?      17697           

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 27, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-27 02:59:46.730326621 +0000 UTC m=+930875.477949717: ☑️ agreed by YuJuncen.
  • 2024-02-27 03:12:54.811215501 +0000 UTC m=+931663.558838612: ☑️ agreed by Leavrth.

@YuJuncen
Copy link
Contributor

/retest-required

@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0c5736b into pingcap:release-7.1 Feb 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants