Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charset,collation: implement GB18030 and 2 collations | tidb-test=pr/2087 #55792

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CbcWestwolf
Copy link
Member

@CbcWestwolf CbcWestwolf commented Sep 2, 2024

What problem does this PR solve?

Issue Number: ref #55791

Problem Summary:

What changed and how does it work?

  • Support charset gb18030, and collations gb18030_bin and gb18030_chinese_ci
  • Adapt some code point for GB18030-2022

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support charset gb18030, and collations gb18030_bin and gb18030_chinese_ci

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 89.89691% with 98 lines in your changes missing coverage. Please review.

Project coverage is 59.7897%. Comparing base (3419bde) to head (260e93d).
Report is 221 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55792         +/-   ##
=================================================
- Coverage   73.0085%   59.7897%   -13.2188%     
=================================================
  Files          1584       1813        +229     
  Lines        443036     688212     +245176     
=================================================
+ Hits         323454     411480      +88026     
- Misses        99870     252061     +152191     
- Partials      19712      24671       +4959     
Flag Coverage Δ
integration 42.9249% <80.0000%> (?)
unit 75.2860% <85.0515%> (+3.1218%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.7090% <ø> (+1.7522%) ⬆️
parser ∅ <ø> (∅)
br 54.4871% <ø> (+9.0288%) ⬆️

@CbcWestwolf CbcWestwolf changed the title [WIP] charset,collate: implement GB18030 and 2 collations [WIP] charset,collate: implement GB18030 and 2 collations | tidb-test=pr/2087 Sep 2, 2024
@CbcWestwolf
Copy link
Member Author

Waiting for tikv/tikv#17467 to pass check_dev_2

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 3, 2024
@CbcWestwolf CbcWestwolf changed the title [WIP] charset,collate: implement GB18030 and 2 collations | tidb-test=pr/2087 charset,collate: implement GB18030 and 2 collations | tidb-test=pr/2087 Sep 3, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2024
@CbcWestwolf CbcWestwolf changed the title charset,collate: implement GB18030 and 2 collations | tidb-test=pr/2087 charset,collation: implement GB18030 and 2 collations | tidb-test=pr/2087 Sep 3, 2024
@CbcWestwolf
Copy link
Member Author

/retest

)

//go:embed gb18030_weight.data
var gb18030WeightData []byte
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we get this *.data file? Is it generated by a program or downloaded from some places?

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 23, 2024
Copy link

ti-chi-bot bot commented Sep 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 12:00:04.859816592 +0000 UTC m=+1480874.600240531: ☑️ agreed by wjhuang2016.

@CbcWestwolf
Copy link
Member Author

/retest

@CbcWestwolf
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2024
@Benjamin2037
Copy link
Collaborator

/retest

@Benjamin2037
Copy link
Collaborator

/approve

@Benjamin2037 Benjamin2037 reopened this Sep 26, 2024
Copy link

ti-chi-bot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Benjamin2037, wjhuang2016
Once this PR has been reviewed and has the lgtm label, please assign d3hunter, xuhuaiyu for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Benjamin2037
Copy link
Collaborator

/retest

@CbcWestwolf
Copy link
Member Author

/cc fzzf678

@ti-chi-bot ti-chi-bot bot requested a review from fzzf678 September 26, 2024 03:26
@CbcWestwolf
Copy link
Member Author

/retest

Copy link

tiprow bot commented Sep 26, 2024

@CbcWestwolf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test 260e93d link true /test tidb_parser_test
fast_test_tiprow 260e93d link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Sep 26, 2024

@CbcWestwolf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 260e93d link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants