plan: return table dual when filter is false/null #7756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impose this check after constant propagation
eurekaka
added
type/enhancement
|
/run-all-tests |
XuHuaiyu
reviewed
Sep 21, 2018
plan/rule_predicate_push_down.go
Outdated
| @@ -34,6 +34,12 @@ func addSelection(p LogicalPlan, child LogicalPlan, conditions []expression.Expr | |||
| return | |||
| } | |||
| conditions = expression.PropagateConstant(p.context(), conditions) | |||
| // Return table dual when filter is constant false or null | |||
There was a problem hiding this comment.
add a . at the end of this comment.
plan/rule_predicate_push_down.go
Outdated
| @@ -55,6 +61,11 @@ func (p *LogicalSelection) PredicatePushDown(predicates []expression.Expression) | |||
| retConditions, child := p.children[0].PredicatePushDown(append(p.Conditions, predicates...)) | |||
| if len(retConditions) > 0 { | |||
| p.Conditions = expression.PropagateConstant(p.ctx, retConditions) | |||
| // Return table dual when filter is constant false or null | |||
plan/rule_predicate_push_down.go
Outdated
| @@ -375,3 +392,21 @@ func deriveOtherConditions(p *LogicalJoin, deriveLeft bool, deriveRight bool) (l | |||
| } | |||
| return | |||
| } | |||
|
|
|||
| // conds2TableDual build a LogicalTableDual if cond is constant false or null | |||
| return nil | ||
| } | ||
| sc := p.context().GetSessionVars().StmtCtx | ||
| if isTrue, err := con.Value.ToBool(sc); (err == nil && isTrue == 0) || con.Value.IsNull() { |
There was a problem hiding this comment.
Will it be possible that err != nil && con.Value.IsNull()
There was a problem hiding this comment.
It is possible, but the constant is a NULL value, the err should be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #7728
What is changed and how it works?
Add false/null check after constant propagation
Check List
Tests