Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtin: add json quote #7832

Merged
merged 4 commits into from
Feb 12, 2019
Merged

Conversation

overbool
Copy link
Contributor

@overbool overbool commented Oct 6, 2018

This is my first PR to tidb, so please be gentle ;-)

What problem does this PR solve?

a part of #7546

What is changed and how it works?

add a built in function json_quote

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has interface methods change

Related changes

  • Need to be included in the release note

This change is Reviewable

@sre-bot
Copy link
Contributor

sre-bot commented Oct 6, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2018

CLA assistant check
All committers have signed the CLA.

@shenli shenli added contribution This PR is from a community contributor. component/expression labels Oct 6, 2018
@shenli
Copy link
Member

shenli commented Oct 6, 2018

@overbool Thanks!

@shenli
Copy link
Member

shenli commented Oct 6, 2018

/ok-to-test

@shenli
Copy link
Member

shenli commented Oct 6, 2018

/run-all-tests

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 7, 2018
@zz-jason
Copy link
Member

@overbool any update?

@overbool
Copy link
Contributor Author

@overbool any update?

Sorry for my delay, I will update it in a few day.

@zz-jason
Copy link
Member

zz-jason commented Jan 2, 2019

@overbool friendly ping 😄 Any update?

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 12, 2019
@codecov-io
Copy link

codecov-io commented Feb 12, 2019

Codecov Report

Merging #7832 into master will increase coverage by <.01%.
The diff coverage is 52.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7832      +/-   ##
==========================================
+ Coverage   67.24%   67.25%   +<.01%     
==========================================
  Files         371      371              
  Lines       77203    77223      +20     
==========================================
+ Hits        51916    51937      +21     
- Misses      20645    20647       +2     
+ Partials     4642     4639       -3
Impacted Files Coverage Δ
expression/distsql_builtin.go 27.94% <0%> (-0.11%) ⬇️
types/json/binary_functions.go 84.33% <0%> (-0.33%) ⬇️
expression/builtin_json.go 76.11% <64.7%> (-0.04%) ⬇️
store/tikv/gcworker/gc_worker.go 41.14% <0%> (-0.43%) ⬇️
util/filesort/filesort.go 76.48% <0%> (+0.31%) ⬆️
ddl/delete_range.go 79.36% <0%> (+4.23%) ⬆️
util/systimemon/systime_mon.go 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad4684...14fd406. Read the comment docs.

@zz-jason zz-jason merged commit 0b363f1 into pingcap:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants