binlog: update config for backward compatibility #9688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix CI. |
|
This looks like a great solution. I have one concern: the new variable is a string with one allowed value besides empty: "auto". Can we validate this so that we reject other values? We could instead make the "mode" a boolean so that it will be validated, but these changes show that a string is more extensible for future changes. |
|
@gregwebs I changed |
Codecov Report
@@ Coverage Diff @@
## master #9688 +/- ##
================================================
+ Coverage 67.3493% 67.3627% +0.0134%
================================================
Files 378 378
Lines 79542 79544 +2
================================================
+ Hits 53571 53583 +12
+ Misses 21193 21185 -8
+ Partials 4778 4776 -2 |
|
/run-all-tests |
|
LGTM |
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-common-test |
1 similar comment
|
/run-common-test |
zz-jason
added
status/LGT2
|
/run-all-tests |
|
/run-common-test tidb-test=pr/739 |
WangXiangUSTC
added a commit
to WangXiangUSTC/tidb
that referenced
this pull request
Mar 22, 2019
This reverts commit 792429d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
pr #9625 break the backward compatibility,
this pr fix it
What is changed and how it works?
Check List
Tests
Related changes