Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

str_to_date function push down (#1961) #2063

Merged
merged 5 commits into from
Jun 17, 2021

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jun 3, 2021

cherry-pick #1961 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2063

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/2063:release-5.0-30db147cf19f

Signed-off-by: JaySon-Huang jayson.hjs@gmail.com

What problem does this PR solve?

Issue Number: #1942

We need to support pushing down the str_to_date function to TiFlash

What is changed and how it works?

Known issue

pingcap/tidb#24928

  1. TiDB has some incompatible parsing results compare with MySQL, the compatible issues are fixed in this PR, but not fixed by TiDB yet (maybe we should also fix them on the TiDB side to make TiDB and TiFlash be consistent)
    • '%b'/'%M' should be case insensitive
    • Parsing an empty string
    • Parsing the day that does not exist in the real world
    • Parsing the "Feb 29th" for leap year and non-leap year
    • Parsing some input for "%r" and "%T"

Related changes

  • Need to cherry-pick to the release branch: 5.0

Check List

Tests

  • Unit test

Side effects

Release note

  • Support pushing down the str_to_date function to TiFlash

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2021
@ti-srebot ti-srebot added this to the v5.0.2 milestone Jun 3, 2021
@JaySon-Huang JaySon-Huang modified the milestones: v5.0.2, v5.0.3 Jun 3, 2021
@JaySon-Huang JaySon-Huang added component/expression type/new-feature Issue or PR for new feature and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2021
dbms/src/Common/MyTime.cpp Outdated Show resolved Hide resolved
dbms/src/Common/MyTime.cpp Outdated Show resolved Hide resolved
@JaySon-Huang
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 17, 2021
@JaySon-Huang
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2021
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@ti-srebot
Copy link
Collaborator Author

@ti-srebot merge failed.

@JaySon-Huang
Copy link
Contributor

/run-all-tests

@JaySon-Huang
Copy link
Contributor

/rebuild

@JaySon-Huang
Copy link
Contributor

/run-all-tests

@JaySon-Huang JaySon-Huang merged commit 67f3c7e into pingcap:release-5.0 Jun 17, 2021
@JaySon-Huang JaySon-Huang deleted the release-5.0-30db147cf19f branch June 17, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/new-feature Issue or PR for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants