Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix that coalesce mistakenly removed nullable from the result column #3394

Merged
merged 3 commits into from
Nov 5, 2021
Merged

Fix that coalesce mistakenly removed nullable from the result column #3394

merged 3 commits into from
Nov 5, 2021

Conversation

fuzhe1989
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #3388

Problem Summary:

Coalesce will align the nullable property of result column with the last argument column. However Const(Nullable) is not treated as nullable and if the last argument column is Const(Nullable) coalesce will return String instead of Nullalbe(String).

What is changed and how it works?

Proposal: xxx

What's Changed:

Align the nullable property of result column with the last argument datatype.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note 

Fix that coalesce mistakenly removed nullable flag from the result column.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 5, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2021
@fuzhe1989
Copy link
Contributor Author

/run-all-tests

windtalker
windtalker approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2021
@windtalker windtalker added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 labels Nov 5, 2021
@fuzhe1989
Copy link
Contributor Author

/run-all-tests

@fuzhe1989
Copy link
Contributor Author

/run-all-tests

@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d2611a5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2021
@fuzhe1989
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 9a7b17e into pingcap:master Nov 5, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 5, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3399.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 5, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3400.

ti-chi-bot added a commit that referenced this pull request Nov 8, 2021
@ti-chi-bot
Fix that coalesce mistakenly removed nullable from the result column (#…
d7566fe 
…3394) (#3400)
@fuzhe1989 fuzhe1989 deleted the fuzhe/fix_3388 branch November 23, 2021 06:27
windtalker added a commit that referenced this pull request Apr 14, 2022
@ti-chi-bot @fuzhe1989
@fzhedu @windtalker
Fix that coalesce mistakenly removed nullable from the result column (#…
ea72b21 
…3394) (#3399)

* update

* Update coalesce_pushdown.test

* Delete gtest_coalesce.cpp

* format code

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>

Co-authored-by: fuzhe1989 <fuzhe1989@gmail.com>
Co-authored-by: Zhuhe Fang <fzhedu@gmail.com>
Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@dragonly dragonly Awaiting requested review from dragonly

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Illegal column for DataTypeNullable:Nullable(String)
3 participants
@fuzhe1989 @ti-chi-bot @windtalker