-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set cop request schema version in client-c #4090
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 576d5e7
|
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
In response to a cherrypick label: failed to apply #4090 on top of branch "release-4.0":
|
In response to a cherrypick label: failed to apply #4090 on top of branch "release-5.0":
|
In response to a cherrypick label: failed to apply #4090 on top of branch "release-5.1":
|
In response to a cherrypick label: failed to apply #4090 on top of branch "release-5.2":
|
In response to a cherrypick label: failed to apply #4090 on top of branch "release-5.3":
|
In response to a cherrypick label: failed to apply #4090 on top of branch "release-5.4":
|
This pr will be manually cherry picked to the cherry pick pr of this pr:#4021 |
What problem does this PR solve?
Issue Number: close #3967
Problem Summary: When do remote read, tiflash doesn't set schema version on the dag request. And if the schema info in the target machine is outdated, it will not try to sync schema, so it may raise some error like "Invalidate column id".
In previous fix: #4021, we just set schema version in tiflash code base. But the schema version is not passed to client-c.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note