Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the problem that expired data was not recycled timely due to slow gc speed #4224

Merged
merged 2 commits into from
Mar 14, 2022
Merged

fix the problem that expired data was not recycled timely due to slow gc speed #4224

merged 2 commits into from
Mar 14, 2022

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Mar 11, 2022 •
edited by flowbehappy
Loading

What problem does this PR solve?

Issue Number: close #4146

Problem Summary: The current gc speed is too slow and the data cannot be reclaimed timely when corresponding region was scheduled to other nodes.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix the problem that expired data was not recycled timely due to slow gc speed

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • JinheLin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed do-not-merge/needs-triage-completed labels Mar 11, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 14, 2022

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ec1b11f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2022
@flowbehappy
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 14, 2022

Coverage for changed files

Filename                                   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Mpp/MPPTunnel.h                            8                 8     0.00%           8                 8     0.00%          14                14     0.00%           0                 0         -
Interpreters/Settings.h                          1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Storages/Transaction/SchemaBuilder.cpp         835               794     4.91%          46                42     8.70%        1030               958     6.99%         488               468     4.10%
Storages/Transaction/SchemaGetter.h              1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          845               803     4.97%          56                51     8.93%        1046               973     6.98%         488               468     4.10%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16853      9456             43.89%    189607  95848        49.45%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit eef6342 into pingcap:master Mar 14, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Mar 14, 2022
@lidezhu @ti-chi-bot
This is an automated cherry-pick of pingcap#4224
b6a2f29 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4251.

@JaySon-Huang JaySon-Huang deleted the fix-gc-parameter branch March 14, 2022 08:27
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Mar 14, 2022
@lidezhu @ti-chi-bot
This is an automated cherry-pick of pingcap#4224
89772f2 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4252.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Mar 14, 2022
@lidezhu @ti-chi-bot
This is an automated cherry-pick of pingcap#4224
44a8829 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4253.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4254.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4255.

ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Mar 14, 2022
@lidezhu @ywqzzy
fix the problem that expired data was not recycled timely due to slow…
aa3623f 
… gc speed (pingcap#4224)

close pingcap#4146

Signed-off-by: ywqzzy <592838129@qq.com>
ywqzzy added a commit to ywqzzy/tiflash_1 that referenced this pull request Mar 14, 2022
@ywqzzy
update.
b54dece 
Signed-off-by: ywqzzy <592838129@qq.com>

update.

Signed-off-by: ywqzzy <592838129@qq.com>

update.

Signed-off-by: ywqzzy <592838129@qq.com>

Split write and ingest throughput (pingcap#4245)

close pingcap#4243

Signed-off-by: ywqzzy <592838129@qq.com>

fix the problem that expired data was not recycled timely due to slow gc speed (pingcap#4224)

close pingcap#4146

Signed-off-by: ywqzzy <592838129@qq.com>

PageStorage: Fix some bugs (pingcap#4212)

ref pingcap#3594

Signed-off-by: ywqzzy <592838129@qq.com>

Make test of CreateTables using affected opts (pingcap#4239)

close pingcap#4235

Signed-off-by: ywqzzy <592838129@qq.com>

BlobStore: remove the old_ids, not need recycle the blob id. (pingcap#4247)

ref pingcap#3594

Signed-off-by: ywqzzy <592838129@qq.com>

support `PartitionTableScan` in TiFlash (pingcap#3876)

close pingcap#3873

Signed-off-by: ywqzzy <592838129@qq.com>

update.

Signed-off-by: ywqzzy <592838129@qq.com>

update.

Signed-off-by: ywqzzy <592838129@qq.com>

support last_day and dayofmonth pushdown to tiflash (pingcap#4183)

close pingcap#4149

Signed-off-by: ywqzzy <592838129@qq.com>
ti-chi-bot added a commit that referenced this pull request Apr 21, 2022
@ti-chi-bot
fix the problem that expired data was not recycled timely due to slow…
940dc19 
… gc speed (#4224) (#4255)

close #4146
ti-chi-bot added a commit that referenced this pull request Jun 2, 2022
@ti-chi-bot
fix the problem that expired data was not recycled timely due to slow…
36992b1 
… gc speed (#4224) (#4254)

close #4146
ti-chi-bot added a commit that referenced this pull request Jun 3, 2022
@ti-chi-bot
fix the problem that expired data was not recycled timely due to slow…
041f18e 
… gc speed (#4224) (#4252)

close #4146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@JinheLin JinheLin JinheLin approved these changes

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Background GC threshold is not optimal on DBaaS env
6 participants
@lidezhu @ti-chi-bot @flowbehappy @sre-bot @JaySon-Huang @JinheLin