From f4b18b395454003f539496e2214dd3031095a476 Mon Sep 17 00:00:00 2001 From: Ti Chi Robot Date: Wed, 15 Nov 2023 15:59:17 +0800 Subject: [PATCH] config(ticdc): change case-sensitive default value (#10049) (#10075) close pingcap/tiflow#10047 --- cdc/api/v2/model_test.go | 2 +- cdc/model/changefeed_test.go | 2 +- pkg/config/replica_config.go | 2 +- tests/integration_tests/api_v2/cases.go | 2 +- tests/integration_tests/cli/run.sh | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cdc/api/v2/model_test.go b/cdc/api/v2/model_test.go index f04fa1386fd..d29d811d1b1 100644 --- a/cdc/api/v2/model_test.go +++ b/cdc/api/v2/model_test.go @@ -30,7 +30,7 @@ import ( // note: this is api published default value, not change it var defaultAPIConfig = &ReplicaConfig{ MemoryQuota: config.DefaultChangefeedMemoryQuota, - CaseSensitive: true, + CaseSensitive: false, EnableOldValue: true, CheckGCSafePoint: true, EnableSyncPoint: false, diff --git a/cdc/model/changefeed_test.go b/cdc/model/changefeed_test.go index c1dd632b375..a13c9890c30 100644 --- a/cdc/model/changefeed_test.go +++ b/cdc/model/changefeed_test.go @@ -146,7 +146,7 @@ func TestVerifyAndComplete(t *testing.T) { StartTs: 417257993615179777, Config: &config.ReplicaConfig{ MemoryQuota: 1073741824, - CaseSensitive: true, + CaseSensitive: false, EnableOldValue: true, CheckGCSafePoint: true, SyncPointInterval: time.Minute * 10, diff --git a/pkg/config/replica_config.go b/pkg/config/replica_config.go index 6dde6c2df06..dbc5ce24d7c 100644 --- a/pkg/config/replica_config.go +++ b/pkg/config/replica_config.go @@ -38,7 +38,7 @@ const ( var defaultReplicaConfig = &ReplicaConfig{ MemoryQuota: DefaultChangefeedMemoryQuota, - CaseSensitive: true, + CaseSensitive: false, EnableOldValue: true, CheckGCSafePoint: true, EnableSyncPoint: false, diff --git a/tests/integration_tests/api_v2/cases.go b/tests/integration_tests/api_v2/cases.go index e5d90e4e88a..926f5a77156 100644 --- a/tests/integration_tests/api_v2/cases.go +++ b/tests/integration_tests/api_v2/cases.go @@ -101,7 +101,7 @@ var customReplicaConfig = &ReplicaConfig{ // defaultReplicaConfig check if the default values is changed var defaultReplicaConfig = &ReplicaConfig{ MemoryQuota: 1024 * 1024 * 1024, - CaseSensitive: true, + CaseSensitive: false, EnableOldValue: true, CheckGCSafePoint: true, EnableSyncPoint: false, diff --git a/tests/integration_tests/cli/run.sh b/tests/integration_tests/cli/run.sh index a412bb6b405..28c12c81f64 100644 --- a/tests/integration_tests/cli/run.sh +++ b/tests/integration_tests/cli/run.sh @@ -69,7 +69,7 @@ function run() { # Update changefeed failed because changefeed is running cat - >"$WORK_DIR/changefeed.toml" <&1) - if [[ ! $changefeed_info == *"\"case_sensitive\":false"* ]]; then + if [[ ! $changefeed_info == *"\"case_sensitive\":true"* ]]; then echo "[$(date)] <<<<< changefeed info is not updated as expected ${changefeed_info} >>>>>" exit 1 fi