Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some bugs when TiCDC setting the timezone #8798

Closed
2 of 6 tasks
Rustin170506 opened this issue Apr 17, 2023 · 2 comments
Closed
2 of 6 tasks

Some bugs when TiCDC setting the timezone #8798

Rustin170506 opened this issue Apr 17, 2023 · 2 comments
Labels
affects-6.5 affects-7.1 area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@Rustin170506
Copy link
Member

Rustin170506 commented Apr 17, 2023 •
edited
Loading

What did you do?

Set the timezone to TiCDC server and sink-uri. How does TiCDC set the time zone internally?

What did you expect to see?

TiCDC uses timezone correctly.

What did you see instead?

  1. We unescape the timezone value twice.
  2. We use the wrong ctx when we get the timezone.
  3. We should not suggest users use CST to create the changefeed in docs.
  4. We should not suggest users use time-zone="" in sink-uri.
  5. Should we only keep the time-zone from the sink-uri? Considering multi-tenancy, we should not use server configurations.
  6. TiCDC can not handle the timezone for some DDLs correctly. We need to add docs for it.

Versions of the cluster

TiCDC version (execute cdc version):

v6.5.1
@Rustin170506 Rustin170506 added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. labels Apr 17, 2023
@Rustin170506 Rustin170506 added severity/moderate needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Apr 17, 2023
@Rustin170506 Rustin170506 mentioned this issue Apr 17, 2023
Merged
@Rustin170506 Rustin170506 added affects-6.5 affects-7.1 and removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Apr 21, 2023
ti-chi-bot pushed a commit that referenced this issue Apr 21, 2023
@Rustin170506
pkg/tz(ticdc): use correct ctx to get timezone (#8799)
8b48bcb 
ref #8798
This was referenced Apr 21, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue May 5, 2023
@ti-chi-bot
pkg/tz(ticdc): use correct ctx to get timezone (#8799) (#8830)
3b9d4d8 
ref #8798
ti-chi-bot bot pushed a commit that referenced this issue May 16, 2023
@ti-chi-bot
pkg/tz(ticdc): use correct ctx to get timezone (#8799) (#8831)
26c5d52 
ref #8798
@nongfushanquan
Copy link
Contributor

/close

@ti-chi-bot ti-chi-bot bot closed this as completed May 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 25, 2023

@nongfushanquan: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nongfushanquan nongfushanquan mentioned this issue May 25, 2023
Merged
16 tasks
@nongfushanquan nongfushanquan mentioned this issue Jun 9, 2023
Merged
17 tasks
@Oreoxmt Oreoxmt mentioned this issue Jun 13, 2023
Merged
17 tasks
This was referenced Jun 14, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-7.1 area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rustin170506 @nongfushanquan