pkg/notify: fix create receiver on closed notifier #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
force-pushed
the
fix-notifier-closed
branch
from
88b4d90
to
59fc7cd
Compare
amyangfei
added
the
needs-cherry-pick-release-4.0
|
/run-all-tests |
|
LGTM |
zier-one
approved these changes
Dec 10, 2020
ti-srebot
approved these changes
Dec 10, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@amyangfei merge failed. |
|
/merge |
|
/run-all-tests |
|
@amyangfei merge failed. |
|
CI failure reason: #1194 |
|
/merge |
|
/run-all-tests |
|
@amyangfei merge failed. |
|
/merge |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Dec 11, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #1199 |
ti-srebot
added a commit
that referenced
this pull request
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #1169
What is changed and how it works?
Closea notifier orStopall receivers belonging to a notifier to recycle resources.Check List
Tests
Release note