Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployments(ticdc): refine the network and volumes #3647

Merged
merged 8 commits into from
Dec 1, 2021
Merged

deployments(ticdc): refine the network and volumes #3647

merged 8 commits into from
Dec 1, 2021

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Nov 28, 2021 •
edited
Loading

What problem does this PR solve?

None

What is changed and how it works?

use service network instead of container network.

And do not exit after test finished.

Otherwise it will ask to create the kafka container first.

Check List

Tests

  • No code

Code changes

None

Side effects

None

Related changes

None

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2021
@Rustin170506
Copy link
Member Author

/cc @asddongmen

Could you please take a look? Thanks! 💚 💙 💜 💛 ❤️

Can you help try it locally?

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2021 •
edited
Loading

Codecov Report

Merging #3647 (22d7e7f) into master (24030f8) will increase coverage by 1.5085%.
The diff coverage is 68.7059%.

@@               Coverage Diff                @@
##             master      #3647        +/-   ##
================================================
+ Coverage   56.5356%   58.0442%   +1.5085%     
================================================
  Files           211        241        +30     
  Lines         22798      24502      +1704     
================================================
+ Hits          12889      14222      +1333     
- Misses         8598       8855       +257     
- Partials       1311       1425       +114

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2021
@Rustin170506 Rustin170506 changed the title deployments(ticdc): use service network instead of container network deployments(ticdc): refine the network and volumes Nov 28, 2021
@Rustin170506
Copy link
Member Author

Usage:

CASE="clustered_index" docker-compose -f ./deployments/ticdc/docker-compose/docker-compose-kafka-integration.yml up

@Rustin170506 Rustin170506 added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 29, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2021
@Rustin170506
Copy link
Member Author

/assign @amyangfei

Could you please help me trigger the merge process? Thanks!

@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 362298f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2021
@Rustin170506
Copy link
Member Author

/run-leak-test

@ti-chi-bot ti-chi-bot merged commit 7702989 into pingcap:master Dec 1, 2021
okJiang pushed a commit to okJiang/tiflow that referenced this pull request Dec 8, 2021
@Rustin170506 @okJiang
deployments(ticdc): refine the network and volumes (pingcap#3647)
e9fc62d
@Rustin170506 Rustin170506 deleted the rustin-patch-deployments branch August 15, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@Ehco1996 Ehco1996 Awaiting requested review from Ehco1996

Assignees

@amyangfei amyangfei

Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Rustin170506 @ti-chi-bot @codecov-commenter @overvenus @asddongmen @Ehco1996 @amyangfei