Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvclient(cdc): remove rate limiter for scanning and error handling #8860

Merged
merged 8 commits into from
May 6, 2023

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Apr 26, 2023

What problem does this PR solve?

Issue Number: close #8858

What is changed and how it works?

Remove rate limiter for scanning and error handling.

Check List

Tests

  • Manual test:

图片

Questions

Will it cause performance regression or break compatibility?

I have testing it with 4 TiKV instances and 85K regions on every TiKV instance. Here is the result:

  • When one TiKV node fails, it can increases TiCDC CPU usage from 300% to 400%;
  • PD CPU usage increases from 100% to 145%;

We can see CPU usage doesn't increase too much. So I think the patch is helpful.

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 26, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 26, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 26, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu hicqu requested a review from asddongmen May 5, 2023 06:02
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 6, 2023
@hicqu
Copy link
Contributor Author

hicqu commented May 6, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 6, 2023

This pull request has been accepted and is ready to merge.

Commit hash: f32154d

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2023
@hicqu
Copy link
Contributor Author

hicqu commented May 6, 2023

/run-verify

@hicqu
Copy link
Contributor Author

hicqu commented May 6, 2023

/test verify

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 6, 2023

@hicqu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 5e06aa7 into pingcap:master May 6, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8897.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 6, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8899.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkpoint lag increases to 7min when one upstream TiKV node fails
4 participants