kv(ticdc): Remove store connect backoff #9740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note
nongfushanquan
approved these changes
Sep 14, 2023
hicqu
approved these changes
Sep 14, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hicqu, nongfushanquan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
approved
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
added
the
cherry-pick-approved
| ) | ||
| } | ||
| if c.config.Debug.EnableKVConnectBackOff { | ||
| newStreamErr = retry.Do(ctx, streamFunc, retry.WithBackoffBaseDelay(500), |
There was a problem hiding this comment.
Suggested change
| newStreamErr = retry.Do(ctx, streamFunc, retry.WithBackoffBaseDelay(500), | |
| newStreamErr = retry.Do(ctx, streamFunc, retry.WithBackoffBaseDelay(100), |
sdojjy
added a commit
to sdojjy/tiflow
that referenced
this pull request
Dec 29, 2023
sdojjy
added a commit
to sdojjy/tiflow
that referenced
this pull request
Dec 29, 2023
sdojjy
added a commit
to sdojjy/tiflow
that referenced
this pull request
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9741
What is changed and how it works?
remove the kv connect backoff logic by default.
6 tikv nodes with about 20k regions, the LAG before this PR is about 6min
after this PR , the LAG is about 40s
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note