Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manager: add a limit to the capture and replay job history #695

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

manager: add a limit to the capture and replay job history #695

wants to merge 1 commit into from
+33 −2

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #693

Problem Summary:
The job history length is unlimited, which may consume much memory if the proxy runs for years.

What is changed and how it works:
Set the length limit to 10.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested a review from bb7133 September 27, 2024 09:11
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from djshow832, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from xhebox September 27, 2024 09:11
@ti-chi-bot ti-chi-bot bot added the size/M label Sep 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@26c66bc). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #695   +/-   ##
=======================================
  Coverage        ?   69.90%           
=======================================
  Files           ?      105           
  Lines           ?    10022           
  Branches        ?        0           
=======================================
  Hits            ?     7006           
  Misses          ?     2524           
  Partials        ?      492
Flag Coverage Δ
unit 69.90% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 Awaiting requested review from bb7133

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit the number of history capture or replay jobs
2 participants
@djshow832 @codecov-commenter