Skip to content

Conversation

@djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #168

Problem Summary:
When 2 TiDB instances are rolling restart, the TiProxy may think both of them are down at one moment. In this case, the TiProxy should refresh the backends immediately.

What is changed and how it works:

  • Do the health check again when there is no backends to return
  • Change the DialTimeout to 2 seconds

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox January 6, 2023 07:23
@xhebox xhebox merged commit 7167d40 into pingcap:main Jan 6, 2023
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
@djshow832 djshow832 deleted the notify_retry branch September 2, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retry different backends when establishing connections

2 participants