Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Density fixes #58

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Density fixes #58

merged 3 commits into from
Dec 14, 2023

Conversation

pinin4fjords
Copy link
Owner

Making a couple of fixes here:

  • In the exploratory plotting function, exclude any samples without a value in the key plotting variable.
  • Reduce the granularity of the density calculation to try and improve performance.
  • Don't mix samples in the density plot- we were getting spikiness due to conflated samples, which is clearly not desirable.

@pinin4fjords pinin4fjords mentioned this pull request Dec 14, 2023
Closed
@pinin4fjords pinin4fjords merged commit 483f86d into develop Dec 14, 2023
1 check passed
@pinin4fjords pinin4fjords deleted the density_fixes branch December 14, 2023 13:20
@pinin4fjords pinin4fjords mentioned this pull request Jan 8, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pinin4fjords