Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TS types #43

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Add TS types #43

merged 3 commits into from
Sep 22, 2020

Conversation

kibertoad
Copy link
Contributor

package.json Outdated
@@ -3,8 +3,21 @@
"version": "1.1.0",
"description": "Extremely fast utf8 only stream implementation",
"main": "index.js",
"type": "commonjs",
"types": "types/index.d.ts",
"files": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I replace it with npmignore then to avoid publishing noise?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcollina Done.

@kibertoad kibertoad requested a review from mcollina September 22, 2020 08:59
@mcollina mcollina merged commit 5a985ba into pinojs:master Sep 22, 2020
mcollina added a commit that referenced this pull request Sep 23, 2020
This reverts commit 5a985ba.

Fixes #44.
@kibertoad kibertoad mentioned this pull request Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants