TS types #45
Merged
TS types #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feat/types-v2 � Conflicts: � package.json
|
I'll just go with the semver-major route when we ship pino v7. Also, I think we'd need https://github.com/fastify/fastify/blob/master/fastify.js#L600-L613 as well. cc @fox1t |
|
okay! I'll add them |
|
@mcollina yes we need them since https://github.com/mcollina/sonic-boom/pull/45/files#diff-88bec6beae84369c0376b56b3bb88fe1R8 exports default and https://github.com/mcollina/sonic-boom/pull/45/files#diff-88bec6beae84369c0376b56b3bb88fe1R10 exports named. @kibertoad good work! |
fox1t
reviewed
Sep 23, 2020
fox1t
approved these changes
Sep 23, 2020
| import { SonicBoom } from "../"; | ||
| import SonicBoomEsm from "../"; | ||
| import { SonicBoom as SonicBoomNamed } from "../"; | ||
| import SonicBoomDefault from "../"; |
There was a problem hiding this comment.
Nice! We should add this import test in every package we maintain :)
|
@kibertoad could you rebase this PR? |
|
@mcollina Sure thing, will focus on everything needed for pino types this evening. |
…feat/types-v2 � Conflicts: � package.json
|
@mcollina Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second iteration of #43, supporting named imports as well. Note that this still doesn't support
import SonicBoom = require('sonic-boom');style of imports the way DefinitelyTyped types did. See fastify/fastify#2404 and fastify/fastify-swagger#282 for in-depth discussion on the topic of why organize exports this way. If we usedexport = SonicBoom;as it was the case in the past, neither named, nor default imports would work withoutesModuleInteropenabled.@mcollina If we want to avoid semver major, I can create a separate PR that includes DefinitelyTyped types verbatim, avoiding any incompatibilities, but not playing nice with proper ESM imports, and then create a separate semver-major one that changes the export signature. Your call.