Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI Go versions #589

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Update CI Go versions #589

merged 3 commits into from
Oct 23, 2024

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Oct 23, 2024

Coverage status is failing due to #589 (comment)

@at-wat at-wat self-assigned this Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.67%. Comparing base (9ea1754) to head (08e411e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #589       +/-   ##
===========================================
- Coverage   58.62%   44.67%   -13.95%     
===========================================
  Files          63       80       +17     
  Lines        3886     5498     +1612     
===========================================
+ Hits         2278     2456      +178     
- Misses       1474     2875     +1401     
- Partials      134      167       +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@at-wat
Copy link
Member Author

at-wat commented Oct 23, 2024

Newer Go seems detecting source files for other architecture and project coverage decreases due to the uncovered code for darwin

@at-wat at-wat requested a review from edaniels October 23, 2024 02:04
@at-wat at-wat merged commit f2a550d into master Oct 23, 2024
6 of 7 checks passed
@at-wat at-wat deleted the update-ci-go-versions2 branch October 23, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants