diff --git a/pkg/app/pipedv1/controller/scheduler_test.go b/pkg/app/pipedv1/controller/scheduler_test.go index e06b126587..f94be6a339 100644 --- a/pkg/app/pipedv1/controller/scheduler_test.go +++ b/pkg/app/pipedv1/controller/scheduler_test.go @@ -183,7 +183,7 @@ func TestExecuteStage(t *testing.T) { expected: model.StageStatus_STAGE_FAILURE, }, { - name: "stage without config, should be set as failed", + name: "stage without config, should be success", deployment: &model.Deployment{ Stages: []*model.PipelineStage{ { @@ -202,7 +202,7 @@ func TestExecuteStage(t *testing.T) { Stages: []config.PipelineStage{}, }, }, - expected: model.StageStatus_STAGE_FAILURE, + expected: model.StageStatus_STAGE_SUCCESS, }, } diff --git a/pkg/configv1/application_test.go b/pkg/configv1/application_test.go index bda095de7b..ab7c0baf6b 100644 --- a/pkg/configv1/application_test.go +++ b/pkg/configv1/application_test.go @@ -404,6 +404,7 @@ func TestGenericTriggerConfiguration(t *testing.T) { Planner: DeploymentPlanner{ AutoRollback: newBoolPointer(true), }, + Pipeline: &DeploymentPipeline{}, }, expectedError: nil, }, @@ -447,6 +448,7 @@ func TestTrueByDefaultBoolConfiguration(t *testing.T) { Planner: DeploymentPlanner{ AutoRollback: newBoolPointer(true), }, + Pipeline: &DeploymentPipeline{}, }, expectedError: nil, }, @@ -468,6 +470,7 @@ func TestTrueByDefaultBoolConfiguration(t *testing.T) { Planner: DeploymentPlanner{ AutoRollback: newBoolPointer(true), }, + Pipeline: &DeploymentPipeline{}, }, expectedError: nil, }, @@ -489,6 +492,7 @@ func TestTrueByDefaultBoolConfiguration(t *testing.T) { Planner: DeploymentPlanner{ AutoRollback: newBoolPointer(true), }, + Pipeline: &DeploymentPipeline{}, }, expectedError: nil, }, @@ -550,6 +554,7 @@ func TestGenericPostSyncConfiguration(t *testing.T) { }, }, }, + Pipeline: &DeploymentPipeline{}, }, expectedError: nil, },