Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRAL-4688 update readme sdk example #580

Merged
merged 1 commit into from
Oct 31, 2024
Merged

GRAL-4688 update readme sdk example #580

merged 1 commit into from
Oct 31, 2024

Conversation

youssef-saber-3
Copy link
Contributor

  • updated the default provided example to re-create the apiClient on each request to comply with the warning
Warning

The pipedrive.ApiClient.instance has been deprecated.

Please, initialise a new pipedrive.ApiClient() instance separately for each request instead.

@dmitriyeff dmitriyeff self-assigned this Oct 31, 2024
dmitriyeff
dmitriyeff approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@dmitriyeff dmitriyeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youssef-saber-3 youssef-saber-3 merged commit 871bbb5 into master Oct 31, 2024
1 check passed
@youssef-saber-3 youssef-saber-3 deleted the GRAL-4688 branch October 31, 2024 10:29
@youssef-saber-3 youssef-saber-3 mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitriyeff dmitriyeff dmitriyeff approved these changes

Assignees

@dmitriyeff dmitriyeff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youssef-saber-3 @dmitriyeff